Skip to content

Surface context snippet in edit modal#253

Merged
JLG-WOCFR-DEV merged 1 commit intomainfrom
codex/add-actions-and-enrich-data-in-blc
Oct 3, 2025
Merged

Surface context snippet in edit modal#253
JLG-WOCFR-DEV merged 1 commit intomainfrom
codex/add-actions-and-enrich-data-in-blc

Conversation

@JLG-WOCFR-DEV
Copy link
Owner

Summary

  • ensure the edit link modal surfaces the stored HTML context so editors can review snippets while updating URLs

Testing

  • npm test

https://chatgpt.com/codex/tasks/task_e_68defbc55eac832e9e1c04b37c463e30

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +1093 to +1108
$response = $remote_request_client->head($normalized_url, $head_args);
$response_code = null;
$needs_get = false;

if (is_wp_error($response)) {
$needs_get = true;
} else {
$response_code = (int) $remote_request_client->responseCode($response);
if (in_array($response_code, [403, 405, 501], true)) {
$needs_get = true;
}
}

if ($needs_get) {
$response = $remote_request_client->get($normalized_url, $get_args);
if (is_wp_error($response)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard recheck requests against unsafe hosts

The new blc_ajax_recheck_link_callback() immediately issues a HEAD/GET request to whatever URL is stored for the row without checking blc_is_safe_remote_host() or any of the host/IP allow lists used during scanning. Links pointing to private or otherwise blocked hosts that the scanner deliberately skipped can now be rechecked manually and trigger network calls to internal resources. This bypasses the existing SSRF safeguards and can hit forbidden hosts on every recheck.

Useful? React with 👍 / 👎.

@JLG-WOCFR-DEV JLG-WOCFR-DEV merged commit 7f2051e into main Oct 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant