Add PHPUnit configuration and expand notification failure tests#413
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.1' | ||
| coverage: none | ||
| - name: Install Composer dependencies | ||
| run: composer install --no-ansi --no-interaction --no-progress | ||
| - name: Run PHP unit tests | ||
| run: composer test:php |
There was a problem hiding this comment.
Gate PHP tests before fixing current failures
The workflow now installs Composer dependencies and runs composer test:php ahead of the existing JS jobs, but the commit summary explicitly notes that this command currently fails with Patchwork exceptions in LinkScanStatusTest. Shipping this as-is will make the entire workflow red on every push or PR, so none of the JavaScript or Playwright checks will run and merges will be blocked. Consider either fixing the failing PHPUnit suite or temporarily marking the step as allowed-to-fail until the PHP tests are stable.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f39f776348832e9fa83eb1cbdee1ca