Skip to content

Add PHPUnit configuration and expand notification failure tests#413

Merged
JLG-WOCFR-DEV merged 1 commit intomainfrom
codex/add-phpunit-configuration-and-tests-setup
Oct 18, 2025
Merged

Add PHPUnit configuration and expand notification failure tests#413
JLG-WOCFR-DEV merged 1 commit intomainfrom
codex/add-phpunit-configuration-and-tests-setup

Conversation

@JLG-WOCFR-DEV
Copy link
Owner

Summary

  • add a phpunit.xml.dist configuration and composer scripts to run the PHP test suite with JUnit output
  • cover the wp_mail failure path in NotificationManagerTest and ignore PHPUnit artifacts in git
  • run composer test:php in CI before the existing Node jobs and document how to execute the PHP suite locally

Testing

  • composer test:php (fails: existing suite raises Patchwork exceptions in LinkScanStatusTest when redefining WordPress functions)

https://chatgpt.com/codex/tasks/task_e_68f39f776348832e9fa83eb1cbdee1ca

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +21
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'
coverage: none
- name: Install Composer dependencies
run: composer install --no-ansi --no-interaction --no-progress
- name: Run PHP unit tests
run: composer test:php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Gate PHP tests before fixing current failures

The workflow now installs Composer dependencies and runs composer test:php ahead of the existing JS jobs, but the commit summary explicitly notes that this command currently fails with Patchwork exceptions in LinkScanStatusTest. Shipping this as-is will make the entire workflow red on every push or PR, so none of the JavaScript or Playwright checks will run and merges will be blocked. Consider either fixing the failing PHPUnit suite or temporarily marking the step as allowed-to-fail until the PHP tests are stable.

Useful? React with 👍 / 👎.

@JLG-WOCFR-DEV JLG-WOCFR-DEV merged commit 202222f into main Oct 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant