Restore WordPress error handling in AJAX link updates#435
Conversation
There was a problem hiding this comment.
💡 Codex Review
The table query now builds WHERE and ORDER BY clauses with unqualified column names even though it still joins wp_posts. In the search filter the clause url LIKE … OR anchor LIKE … OR post_title LIKE … no longer prefixes post_title with the links alias, and the ordering fallback uses id instead of links.id. Because wp_posts also exposes post_title and ID, MySQL will raise "Column … is ambiguous" as soon as a search term or default ordering runs, breaking the broken-link list page. These conditions need to keep the table alias (links.post_title, links.id, etc.) to execute reliably.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
blc_is_wp_error()helper and switch plugin code to use it consistentlyTesting
https://chatgpt.com/codex/tasks/task_e_68f9fe66f3e0832ea58e0966b08abbd4