Right diagonal button bottom vs top #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Here are the two examples on mobile |
Collaborator
|
I agree that there is wasted space. However, I think this is more to do with the size of the arrows, the padding around them, and the table spacing in general. Having it in the top-right also gives a symmetry to the entire bingo card. Of course, this is all subjective. :) 
|
Collaborator
|
I just checked in dev inspector. On the new design, even with the top-right diagonal button, the images are 50x50px on an iPhone SE (screen width 375px). On the old design, they are 35px. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was wondering about this and wanted to get some review. Diagonal arrow on the right side of the screen wastes space, especially bad on mobile phones as it really shrinks image previews. But moving it to the bottom may hide it on desktop screens which are wider but shorter.
Any thoughts on this?