restore fallback behaviour for dx12 compiler#32
Merged
JMS55 merged 1 commit intoJMS55:wgpu24from Feb 9, 2025
Merged
Conversation
|
I'm personally against this (even though I implemented falling back to FXC from DXC in wgpu originally). Silently falling back to FXC breaks things without a clear reason why, and we should really be pushing users to not use FXC at all. |
Author
|
I'm ok with changing that, I've been trying the statically linked dxc and it seems to work well this was the keep-behaving-the-same-as-before fix to do the wgpu update, let's talk about changing it in Bevy repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Dx12CompilerDx12Compiler::Dxcin wgpu 23 fallbacked toDx12Compiler::Fxcwhen the dlls were not found. Restore that