- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10
Interpro redo #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpro redo #53
Conversation
| ✅ Deploy Preview for molevolvr ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| Apologies for the trickling commits. This should be stable and ready to review. | 
| For the record, the old Nightingale version at https://molevolvr.netlify.app/testbed is incredibly slow for me in Chrome 136.0.7103.114 on OS X 15.4.1. It takes something like 15-30 seconds to display the page, and the IPR widget is also very laggy. I tried it without extensions enabled with the same result. I'm surprised by that since I don't remember that being the case when I last reviewed it. It's much more performant on Firefox. | 
| Indeed, I also don't remember it being that slow. I can only think of a few possible causes for the sudden change: 
 In any case, I wasn't happy with Nightingale for other reasons. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The new widget appears to be much more performant than Nightingale; kudos. I tried it out on my Android phone, and pinch-to-zoom and drag are working as expected in the new widget.
This is a small thing, and I'll have to let the bioinformaticians weigh in on whether this is important, but I noticed in comparing it to Nightingale that it's not immediately obvious in the new widget what the full extent of the range is. It would be nice to see both the full range's start and end positions somewhere, and optionally the start and end positions of the currently visible area. It'd also be nice for the scrollbar to be closer to the position scale so you can better tell the area you're viewing, but I realize that's impractical with the native scrollbar.
This may be outside the scope of this PR, but I wonder if we should include some inline documentation on how to use the widgets, since users might have seen Nightingale before, but not this. For example, they might not know to use the mouse wheel to zoom on desktop, or that they can pan the entire sequence (rather than dragging, which might take a while) with the scrollbar at the bottom.
| 
 Okay I've just done this for now. Should be sufficient for now, unless we observe users having problems. | 

Compare the Netlify preview here to the
mainone at https://molevolvr.netlify.app/testbed, where I re-enabled the Nightingale IPR viz so you could compare. Note that it seems to slow down the page, which is why I had commented it out originally while developing other components.