Skip to content

Conversation

@vincerubinetti
Copy link
Member

@vincerubinetti vincerubinetti commented Jun 12, 2025

  • simplify flex component props, e.g. direction="column" -> column, since it's used everywhere. find+replace whole app.
  • change heading component to register/unregister itself in global list of headings
  • consistent use of data attribute for active state styles
  • tweak table of contents styles
  • instead of requerying for all headings on any document mutation (expensive*), render table of contents from global reactive list of headings
  • include icons in table of contents entries
  • clean up and compactify about page (original impetus for making TOC look and behave better)

* On any modern machine though, probably not a humanly perceptible difference. Also the expense will be limited by the fact that we should never have as many things on one page as is currently on the testbed page.

@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for molevolvr ready!

Name Link
🔨 Latest commit 64130f5
🔍 Latest deploy log https://app.netlify.com/projects/molevolvr/deploys/684b4a9970365800081a1ad4
😎 Deploy Preview https://deploy-preview-59--molevolvr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave the code a quick look; the code changes make sense as far as I can tell, and seem cleaner.

IMO the about page looks way more organized than before. I like the new TOC styling, and especially the icons in it for each header. Nice work!

@vincerubinetti vincerubinetti merged commit c7bee54 into main Jun 27, 2025
4 checks passed
@vincerubinetti vincerubinetti deleted the toc-icons branch June 27, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants