Misc improvements - #256
Merged
Merged
Conversation
on upload failures that result in dangling files on fs, we want to overwrite it's content before sweeper runs
if file doesn't get deleted it will be "sweept away" by sweeper task
I theorize that it is possible for two or more uploads to be made to the same document name at the same time. Deno does not implicitly request an fs lock, and it may be slower to request it than to write first the record to the database. The downside is when an upload is interrupted and it is no longer possible to reuse the same name until the sweeper task runs
Related: #257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.