Merged
Conversation
added current library as attribute of HTTPClient class, refactored methods accordingly, changed comments to match and renamed "performFetch" to "performRequest"
deleted unused icons folder and old index(1).html renamed branch
# Conflicts: # http/HTTPClient.js # index.html # src/main.js
* Adding Entry Preview Feature to the Nodes * Adding Entry Preview to the child nodes * WIP merged cayw and getting entry preview functionality * removed unused imports * Fixed displaying BibEntry nodes' previews :3 * Minor format consistency check * fixing entry preview bugs * Fixed hiding popovers upon deleting nodes * Prevented editing BibEntries' topics (also fixed small bug when their previews dissapeared upon double clicks) --------- Co-authored-by: Shalabi <Mohamed.Shalabi@Student.HTW-Berlin.de> Co-authored-by: Robert Koch <Robert.Koch@Student.HTW-Berlin.de>
koppor
reviewed
Jun 22, 2025
| } | ||
| // Altered lines: | ||
| let nodeType = node.data.type; | ||
| if (nodeType === 'BIBE') { |
Member
There was a problem hiding this comment.
What is the long form for BIBE. Maybe, you could use BTX (for BibTeX) - or just BibEntry to be in line with the term used in JabRef?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Implementing BibEntry node functionalities.
📑 TODOs: