Closed
Conversation
This was referenced Aug 19, 2025
6713d0c to
bbd19d9
Compare
Member
|
Failing tests for non-maintainers?? What a privilege to be a maintainer 😆 |
Member
|
Are there any clashes with how we organize imports? |
InAnYan
approved these changes
Sep 13, 2025
Member
Author
We will follow the import guide of prettier-java - and ignore our wishes. (I don't read imports, I just want to have them conflict-free) WDYT? |
Member
Author
|
Do we accept the issue jhipster/prettier-java#777 for now? |
Member
|
Oh, sorry, I deleted my message because mobile github messed up the history of conversation. Tldr; accept everything as is |
Member
|
It's not ideal, but if it allows me to format and forget - then I will go for it |
Member
Author
|
We opted to continue with IntelliJ - JabRef#13885 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use prettier-java.
Seems to be maintained. And better than two years ago (this PR is a follow-up to JabRef#10646)
Notes:
package.jsonnevertheless)Note on 80 chars
It seems to be well-thought of
It is not the hard upper allowed line length limit. It is a way to say to Prettier roughly how long you’d like lines to be.
Source: https://prettier.io/docs/options
Steps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)