Skip to content

Fix main table sorting#12371

Merged
koppor merged 3 commits intomainfrom
fix-sorting
Jan 9, 2025
Merged

Fix main table sorting#12371
koppor merged 3 commits intomainfrom
fix-sorting

Conversation

@LoayGhreeb
Copy link
Copy Markdown
Member

@LoayGhreeb LoayGhreeb commented Jan 9, 2025 •
edited
Loading

Follow-up to #11510

Fixed issues with main table sorting:

  • When inserting a new entry, it was inserted in the middle of the table instead of at the end.
  • When removing sorting from the table, the table did not revert to its original (insertion) order.

These issues due to a JavaFX bug: https://bugs.openjdk.org/browse/JDK-8301761 (The sorting of the SortedList can become invalid).

Attempted to fix the issue in the jfx, but the PR was closed: openjdk/jfx#1519.
This workaround implements a similar solution to the one proposed in the closed PR (considering the insertion index of the entries while comparing them).

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit c11f8fc Jan 9, 2025
@koppor koppor deleted the fix-sorting branch January 9, 2025 23:04
Siedlerchr added a commit to ar-rana/jabref that referenced this pull request Jan 13, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into feature/arXivId
0308a0b 
* upstream/main: (29 commits)
  Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (JabRef#12384)
  Bump src/main/resources/csl-styles from `080516e` to `6bae16d` (JabRef#12387)
  Bump src/main/resources/csl-locales from `96d704d` to `9914965` (JabRef#12386)
  Bump buildres/abbrv.jabref.org from `93a2cad` to `e74e6eb` (JabRef#12385)
  Bump org.openrewrite.rewrite from 6.29.3 to 7.0.0 (JabRef#12383)
  Bump org.glassfish.jersey.core:jersey-server from 3.1.9 to 3.1.10 (JabRef#12381)
  Bump org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2 (JabRef#12380)
  fix linux build not updated
  Refactor the isUnwantedText (JabRef#12369)
  Searching for entries with empty field (JabRef#12376)
  Downgrade Ubuntu (JabRef#12375)
  Downgrade Ubuntu
  Fix main table sorting (JabRef#12371)
  fix bib and pdf name (JabRef#12366)
  use v4 instead of master
  Update abbrv.jabref.org (JabRef#12365)
  Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (JabRef#12363)
  Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (JabRef#12362)
  Bump tech.units:indriya from 2.2.1 to 2.2.2 (JabRef#12361)
  Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (JabRef#12360)
  ...

# Conflicts:
#	buildres/abbrv.jabref.org
#	src/main/resources/csl-styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LoayGhreeb @calixtus @koppor