Skip to content

Enhance PR validation actions#13850

Merged
calixtus merged 6 commits intoJabRef:mainfrom
subhramit:actions
Sep 11, 2025
Merged

Enhance PR validation actions#13850
calixtus merged 6 commits intoJabRef:mainfrom
subhramit:actions

Conversation

@subhramit
Copy link
Copy Markdown
Member

@subhramit subhramit commented Sep 10, 2025

By default, specifying no types: under pull_request: would not make the PR title/description format tests re-run if someone edited the PR title or description (it would implicitly run only for opened, reopened and synchronize).
This fixes it.

Also some miscellaneous fixes e.g. comment workflow name mismatch for Determine issue number and check PR title format job, etc.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@subhramit subhramit requested a review from koppor September 10, 2025 14:09
@subhramit
Copy link
Copy Markdown
Member Author

subhramit commented Sep 10, 2025

I removed a mandatory check after opening PR to test.
So far, test fails as expected, waiting for the comment.

@subhramit
Copy link
Copy Markdown
Member Author

subhramit commented Sep 10, 2025

Comment doesn't come up :/
Update: workflow_run executes from main and not the PR branch, so should be fine.

@trag-bot
Copy link
Copy Markdown

trag-bot bot commented Sep 10, 2025

@trag-bot didn't find any issues in the code! ✅✨

@calixtus calixtus added this pull request to the merge queue Sep 10, 2025
Merged via the queue into JabRef:main with commit 31633d8 Sep 11, 2025
37 checks passed
@calixtus calixtus deleted the actions branch September 11, 2025 00:09
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
* upstream/main:
  fix langchain module errors (#13853)
  Enhance PR validation actions (#13850)
@koppor koppor mentioned this pull request Sep 21, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants