Skip to content

Fix: Refactor BibtexParser to use ranges of articles and work with them in the LSP instead of string matching#13862

Merged
koppor merged 16 commits intoJabRef:mainfrom
palukku:add-ranges-to-lsp
Sep 13, 2025
Merged

Fix: Refactor BibtexParser to use ranges of articles and work with them in the LSP instead of string matching#13862
koppor merged 16 commits intoJabRef:mainfrom
palukku:add-ranges-to-lsp

Conversation

@palukku
Copy link
Copy Markdown
Member

@palukku palukku commented Sep 12, 2025

Closes palukku#42 & Closes palukku#45 & Closes palukku#50

In #13746 the ranges of the fields and entries it self got added now the lsp utilizes these ranges instead of simple string matching.

Also aliases are now handled so if there the error occurs on an alias field the alias is also correctly detected.

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

koppor
koppor previously approved these changes Sep 13, 2025
koppor
koppor previously approved these changes Sep 13, 2025
@koppor koppor enabled auto-merge September 13, 2025 11:52
@trag-bot
Copy link
Copy Markdown

trag-bot bot commented Sep 13, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Sep 13, 2025
Merged via the queue into JabRef:main with commit 3e886af Sep 13, 2025
35 checks passed
@koppor koppor deleted the add-ranges-to-lsp branch September 13, 2025 15:01
Siedlerchr added a commit that referenced this pull request Sep 13, 2025
* upstream/main:
  Chronological navigation in libraries (#13863)
  Adapt code style (#13874)
  LSP Refactor to use ranges instead of string matching (#13862)
  Use jspecify (#13873)
  changed Keyword.of to accept List<String> instead of varargs (#13871)
@palukku palukku changed the title LSP Refactor to use ranges instead of string matching Fix: Refactor BibtexParser to use ranges of articles and work with them in the LSP instead of string matching Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP doesn't report all parsing errors Journal abbreviation not found message is not on "journal" field Precise error location on field error

4 participants