Consistent casing in fieldnames by calixtus · Pull Request #13867 · JabRef/jabref

calixtus · 2025-09-12T22:03:43Z

Fixes #10590

see attached ADR

Steps to test

Look at entry editor and preferences for entry types

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

…to fix-inconsistent-casing

…sing # Conflicts: # jablib/src/main/java/org/jabref/model/entry/field/Field.java

…sing # Conflicts: # config/IntelliJ Code Style.xml # jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckDialogViewModel.java # jabgui/src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java # jabgui/src/main/java/org/jabref/gui/fieldeditors/identifier/DoiIdentifierEditorViewModel.java # jabgui/src/main/java/org/jabref/gui/mergeentries/threewaymerge/fieldsmerger/FieldMergerFactory.java # jabgui/src/main/java/org/jabref/gui/util/FieldsUtil.java # jablib/src/main/java/org/jabref/model/entry/field/FieldFactory.java

koppor · 2025-09-13T21:27:16Z

jablib/src/main/java/org/jabref/model/entry/field/FieldTextMapper.java

+
+public class FieldTextMapper {
+    public static String getDisplayName(Field field) {
+        if (field.isStandardField()) {


Future work is to add make use of org.jabref.model.entry.BibEntryTypesManager#isCustomOrModifiedType here. It is hard, because the parameter has the field only - and the field does not have a reference to its parent.

koppor · 2025-09-13T21:27:39Z

jablib/src/main/java/org/jabref/model/entry/field/FieldTextMapper.java

+    public static String getDisplayName(Field field) {
+        if (field.isStandardField()) {
+            StandardField standardField = (StandardField) field;
+            return switch (standardField) {


Nice start so that we could customize

urldate to URL date or even Date of URL.

jablib/src/main/java/org/jabref/model/entry/field/FieldTextMapper.java

jablib/src/test/java/org/jabref/model/entry/field/FieldFactoryTest.java

…fix-inconsistent-casing

jablib/src/main/java/org/jabref/logic/exporter/OOCalcDatabase.java

jablib/src/main/java/org/jabref/model/entry/field/FieldTextMapper.java

jablib/src/test/java/org/jabref/logic/bibtex/BibEntryWriterTest.java

koppor · 2025-09-14T18:09:16Z

...va/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckResultTxtWriterTest.java

                Field Presence Consistency Check Result

-                | entry type | citation key | Custom | Pages | Title |
+                | entry type | citation key | custom | Pages | Title |


Discussion: I think, we should use the field name instead of the display name --> follow-up for someone else :)

koppor

Thank you for your effort and endurance!!

* Prototype * Add ADR * Modify ADR * Fix tests * Fix merge conflict * CHANGELOG.md * Fix APA fields * Refine ADR * typo * Code formatting * Remove capitalization from orfield * Comment to ADR * Remove forced lowercase of field names in bib file * Fix tests * Fix more tests * Add special case for OpenOffice/LibreOffice * Rewrite * Suggestions * Fix tests --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>

trag-bot · 2025-09-14T21:36:01Z

@trag-bot didn't find any issues in the code! ✅✨

koppor · 2025-09-14T21:38:13Z

GitHub's UI does something wrong - d741bac is the right commit

This one is NOT in:

trag-bot · 2025-09-14T21:39:13Z

@trag-bot didn't find any issues in the code! ✅✨

* upstream/main: Add new check for format (#13909) Consistent casing in fieldnames (#13867) Revert "Pressing TAB in last field in entry editor moves focus to the next ta…" (#13912) Fix YAML Fix on-pr-opened-updated.yml syntax Pressing TAB in last field in entry editor moves focus to the next tab's first field (#13870) Modularize JabSrv (#13908) New translations jabref_en.properties (Italian) (#13907) Remove wrong `assert` statement (#13906) Add .git-blame-ignore-revs (#13884) Do not show transprot info messages (#13904) Pubmed api key support (#13899) Fix warnings for native access Fix automerge workflow (#13903) Add comment on issue on binary (#13902) Have checkstyle and VCS configuration distributed (#13900) Add unknown field to lsp consistency check (#13880) Put config for general tab if missing (#13901) Fix autosave manager exception on shutdown (#13882)

Prototype

e2f526d

calixtus changed the title ~~Consistent naming of fields~~ Consistent casing in fieldnames Sep 12, 2025

calixtus added component: entry-editor project: jabcon labels Sep 12, 2025

calixtus added 7 commits September 13, 2025 10:59

Add ADR

344cdb5

Modify ADR

9e037d8

Fix tests

adec9ec

Merge branch 'main' into fix-inconsistent-casing

e442cc1

Fix merge conflict

b1b9a8e

CHANGELOG.md

29054a9

Fix APA fields

33013d8

calixtus marked this pull request as ready for review September 13, 2025 10:38

calixtus requested a review from koppor September 13, 2025 10:38

calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 13, 2025

koppor and others added 7 commits September 13, 2025 15:07

Refine ADR

dcbf1cb

Merge branch 'fix-inconsistent-casing' of github.com:JabRef/jabref in…

f073260

…to fix-inconsistent-casing

typo

0988273

Merge remote-tracking branch 'upstream/main' into fix-inconsistent-ca…

adf2a35

…sing # Conflicts: # jablib/src/main/java/org/jabref/model/entry/field/Field.java

Code formatting

7407839

Merge branch 'main' into fix-inconsistent-casing

bf06837

koppor requested changes Sep 13, 2025

View reviewed changes

github-actions bot added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Sep 13, 2025

koppor mentioned this pull request Sep 13, 2025

Inconsistent casing of custom field names #10590

Closed

2 tasks

calixtus added 3 commits September 13, 2025 23:37

Remove capitalization from orfield

54bfeab

Merge remote-tracking branch 'upstream/fix-inconsistent-casing' into …

202aa53

…fix-inconsistent-casing

Comment to ADR

ad6a119

koppor previously approved these changes Sep 13, 2025

View reviewed changes

Remove forced lowercase of field names in bib file

5d11e29

Merge branch 'main' into fix-inconsistent-casing

4e96ca9

koppor requested changes Sep 14, 2025

View reviewed changes

calixtus added 2 commits September 14, 2025 21:06

Suggestions

bb8c653

Merge branch 'main' into fix-inconsistent-casing

5c11c9e

koppor previously approved these changes Sep 14, 2025

View reviewed changes

koppor enabled auto-merge September 14, 2025 19:57

Fix tests

d741bac

calixtus dismissed koppor’s stale review via d741bac September 14, 2025 20:05

koppor previously approved these changes Sep 14, 2025

View reviewed changes

koppor added this pull request to the merge queue Sep 14, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 14, 2025

koppor added this pull request to the merge queue Sep 14, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 14, 2025

calixtus added this pull request to the merge queue Sep 14, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 14, 2025

calixtus dismissed koppor’s stale review via d741bac September 14, 2025 21:34

calixtus force-pushed the fix-inconsistent-casing branch from acada03 to d741bac Compare September 14, 2025 21:34

koppor enabled auto-merge September 14, 2025 21:38

koppor approved these changes Sep 14, 2025

View reviewed changes

calixtus removed the status: changes-required Pull requests that are not yet complete label Sep 14, 2025

koppor added this pull request to the merge queue Sep 14, 2025

Merged via the queue into main with commit ccda46d Sep 14, 2025
84 of 85 checks passed

koppor deleted the fix-inconsistent-casing branch September 14, 2025 21:57

calixtus mentioned this pull request Oct 19, 2025

Fix Nullwarnings - A #14116

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Consistent casing in fieldnames#13867

Consistent casing in fieldnames#13867
koppor merged 29 commits intomainfrom
fix-inconsistent-casing

calixtus commented Sep 12, 2025 •

edited

Loading

Uh oh!

koppor Sep 13, 2025

Uh oh!

koppor Sep 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koppor Sep 14, 2025

Uh oh!

koppor left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trag-bot bot commented Sep 14, 2025

Uh oh!

koppor commented Sep 14, 2025

Uh oh!

trag-bot bot commented Sep 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

calixtus commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

koppor Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

koppor Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koppor Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trag-bot bot commented Sep 14, 2025

Uh oh!

koppor commented Sep 14, 2025

Uh oh!

trag-bot bot commented Sep 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

calixtus commented Sep 12, 2025 •

edited

Loading