Updatejfx25 by Siedlerchr · Pull Request #13933 · JabRef/jabref

Siedlerchr · 2025-09-17T09:25:59Z

Release notes: https://gluonhq.com/products/javafx/openjfx-25-release-notes/

Closes _____

Steps to test

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
[.] I manually tested my changes in running JabRef (always required)
[.] I added JUnit tests for changes (if applicable)
[.] I added screenshots in the PR description (if change is visible to the user)
[.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

* upstream/main: New translations jabref_en.properties (Italian) (#13725) Minor code style updates (#13722) Fix: Make FileUtil.relativize symlink-aware (#13553) New Crowdin updates (#13720) Bump org.glassfish.jersey.core:jersey-server in /versions (#13714) Enable UseObjectNotifyAll (#13718) Bump com.dlsc.gemsfx:gemsfx from 3.3.5 to 3.4.2 in /versions (#13717) Update on-issue-comment.yml Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.12.1 to 3.13.0 (#13716) Bump org.openrewrite.rewrite from 7.12.1 to 7.14.0 (#13715) Bump org.glassfish.jersey.inject:jersey-hk2 in /versions (#13713) feat(git): add “Share to GitHub” flow (#13677) Bump jablib/src/main/resources/csl-styles from `292aec3` to `1194364` (#13712) Bump jablib/src/main/abbrv.jabref.org from `cfe719f` to `a97f9c6` (#13711) Bump jablib/src/main/resources/csl-locales from `e2de1e3` to `fa56de1` (#13710) Add noop Git Config System Reader to prevent usage of real world stuff into jgit (#13703) Added static (stream & preferences) constructors to BibDatabaseContext (#13694) New Crowdin updates (#13698) fix git modules requires and uses (#13696) Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard (#13633)

* upstream/main: (32 commits) Fix path (#13769) Mode aware consistency check (#13584) Refine JBang check (#13765) Add Language Server to the UI and add the integrity/consistency check (#13697) Fix/remove comment code (#13763) New Crowdin updates (#13760) Bump org.openrewrite.rewrite from 7.14.0 to 7.14.1 (#13757) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13756) Bump dev.langchain4j:langchain4j-bom from 1.2.0 to 1.3.0 in /versions (#13755) Bump jablib/src/main/resources/csl-locales from `fa56de1` to `e29c453` (#13754) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13753) Bump org.mockito:mockito-core from 5.18.0 to 5.19.0 in /versions (#13752) Bump actions/upload-pages-artifact from 3 to 4 (#13751) Migrate fetchers to Search.g4 ANTLR parser. (#13691) [Junie]: fix: resolve IllegalArgumentException for non-absolute URIs (#13669) Add auto-renaming of linked files on entry data change (#13295) Walkthrough additions (#13745) Switch from zulu to corretto (#13749) New Crowdin updates (#13747) Fix copy to (#13741) ...

* upstream/main: Add missing variables Reformat BibTex in Show BibTex Source (#13761) Auto publish before JBang tests (#13779) Hotfix: calling of publish.yml Support BibLaTeX datamodel validations (#13693) Auto add and remove of "status: changes-required" label (#13778) New Crowdin updates (#13777) Restore local-only Git behavior for SLR to fix repository initialization error (#13775) Use vanilla hashset (#13771) Fix Springer Fetcher names (#13770) Fix condition Publish SNAPSHOT on jablib change (#13774) Adapt as per new set of checks (#13772) Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750)

* upstream/main: (54 commits) Split relativizeSymlinks parameterized tests in separate tests (#13782) Update the search syntax highlight for web search (#13801) Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833) Fix typos in CHANGELOG.md (#13826) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831) Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828) add: CAYW endpoint formats (#13785) New Crowdin updates (#13823) chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822) Add support for automatic ICORE conference ranking lookup [#13476] (#13699) New Crowdin updates (#13820) Initialize search bar auto-completion with real database context (no tab switch needed) (#13816) Fixes #13274: Allow cygwin-paths on Windows (#13297) Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814) changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767) ...

* upstream/main: Fix typo in PR template Fix: No exception if file is not within a git repository (#13839) Fix lsp4j modules (#13835) New Crowdin updates (#13837)

* upstream/main: Fix NoSuchElementException in ThreeWayMerge dialog (#13838) Keep global search bar open when keep on top pin is selected (#13846) Spell "BibDesk" with capital "D" (#13847) fix: Improper icon sizing with respect to font size (#13841) Ensure latest JDK veriant (#13843)

* upstream/main: fix langchain module errors (#13853) Enhance PR validation actions (#13850)

* upstream/main: New Crowdin updates (#13865) Fix unresponsive "Check Consistency" dialog (#13864) Fix several aux group issues (#13861) Add integrity check to cli (#13848) Add sbom file and remove external libraries (#13859) Fix Tagsfield in Keyword editor (#13858) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13857) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13856)

* upstream/main: Chronological navigation in libraries (#13863) Adapt code style (#13874) LSP Refactor to use ranges instead of string matching (#13862) Use jspecify (#13873) changed Keyword.of to accept List<String> instead of varargs (#13871)

* upstream/main: Add hint on auto formatting (#13886) Add ADR-0050 on code formatter (#13895) Reformat codebase (more carefully) (#13885) New Crowdin updates (#13892) Fix record wrapping (#13889) Fix JavaDoc (#13888) Improve IntelliJ settings (#13887) Manual code reformattings (#13883)

* upstream/main: Add new check for format (#13909) Consistent casing in fieldnames (#13867) Revert "Pressing TAB in last field in entry editor moves focus to the next ta…" (#13912) Fix YAML Fix on-pr-opened-updated.yml syntax Pressing TAB in last field in entry editor moves focus to the next tab's first field (#13870) Modularize JabSrv (#13908) New translations jabref_en.properties (Italian) (#13907) Remove wrong `assert` statement (#13906) Add .git-blame-ignore-revs (#13884) Do not show transprot info messages (#13904) Pubmed api key support (#13899) Fix warnings for native access Fix automerge workflow (#13903) Add comment on issue on binary (#13902) Have checkstyle and VCS configuration distributed (#13900) Add unknown field to lsp consistency check (#13880) Put config for general tab if missing (#13901) Fix autosave manager exception on shutdown (#13882)

* upstream/main: Refine .gitginore (#13931) Hotfix: Markdown lint issue Update custom code style decision document Chore(deps): Bump org.openrewrite.rewrite from 7.15.0 to 7.16.0 (#13923) New translations jabref_en.properties (French) (#13928) Chore(deps): Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#13927) Chore(deps): Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13924) Chore(deps): Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13921) Chore(deps): Bump org.yaml:snakeyaml from 2.4 to 2.5 in /versions (#13922) Chore(deps): Bump tj-actions/changed-files from 45 to 47 (#13917) Chore(deps): Bump plbstl/first-contribution from 3 to 4 (#13916) Share .idea/codeStyles/Project.xml (#13913) Chore(deps): Bump actions/github-script from 7 to 8 (#13915) Chore(deps): Bump jbangdev/jbang-action from 0.129.0 to 0.130.0 (#13914)

koppor · 2025-09-17T10:19:37Z

 Execution failed for ExtraJavaModuleInfoTransform: /Users/runner/.gradle/caches/modules-2/files-2.1/org.openjfx/jdk-jsobject/25/bf900cfdd3ed80ab1f0d68f1d50ea590354cf4c/jdk-jsobject-25.jar.
Build cache key for ExtraJavaModuleInfoTransform: /Users/runner/.gradle/caches/modules-2/files-2.1/org.openjfx/jdk-jsobject/25/bf900cfdd3ed80ab1f0d68f1d50ea590354cf4c/jdk-jsobject-25.jar is 382be7c78802aeb9ba87628331058ee9
         > [requires directives from metadata] Cannot read metadata for 'jdk.jsobjectEmpty': Could not find org.openjfx:jdk-jsobject:.

Siedlerchr · 2025-09-17T10:27:23Z

Yeah this is weird, previously we had ea25 for this but now it shoud be available

Siedlerchr · 2025-09-17T18:19:59Z

sonatype snapshot issues

koppor · 2025-09-19T06:57:41Z

Theme Manager tests fail. May I ping you @Yubo-Cao

org.jabref.gui.theme.ThemeManagerTest

  Test themeManagerUsesProvidedTheme() FAILED

  java.lang.IllegalStateException: Not on FX application thread; currentThread = Test worker
      at org.jabref/org.jabref.gui.theme.ThemeManagerTest.themeManagerUsesProvidedTheme(ThemeManagerTest.java:58)

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

trag-bot · 2025-09-21T17:05:01Z

@trag-bot didn't find any issues in the code! ✅✨

koppor · 2025-09-21T17:06:07Z

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java

+            updateThemeSettings();
+        } else {
+            // Normally ThemeManager is only instantiated by JabGui and therefore already on the FX Thread, but when it's called from a test (e.g. ThemeManagerTest) then it's not on the fx thread
+            UiTaskExecutor.runInJavaFXThread(() -> {


Isn't it OK to always use this? The check whether in FXApplicationThread should be done inside that in all cases?

Sure, but runOnFxThread just forwards to Platform.runLater, which will put the call in a queue to be executed when it's ready. https://stackoverflow.com/questions/24043420/why-does-platform-runlater-not-check-if-it-currently-is-on-the-javafx-thread

trag-bot · 2025-09-21T17:08:36Z

@trag-bot didn't find any issues in the code! ✅✨

github-actions · 2025-09-21T17:17:22Z

The build of this PR is available at https://builds.jabref.org/pull/13933/merge.

Siedlerchr added 15 commits August 14, 2025 19:22

fix git modules requires and uses

b6451f1

Merge remote-tracking branch 'upstream/main'

511549f

* upstream/main: Fix typo in PR template Fix: No exception if file is not within a git repository (#13839) Fix lsp4j modules (#13835) New Crowdin updates (#13837)

Merge remote-tracking branch 'upstream/main'

aa1818f

* upstream/main: fix langchain module errors (#13853) Enhance PR validation actions (#13850)

update javafx 25

7c84fe2

update richtext

a8049ea

Siedlerchr added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Sep 17, 2025

Siedlerchr added 3 commits September 17, 2025 11:33

fix version

f2ff92e

try to fix module?

4f3e257

try to fix module?

421ca59

Siedlerchr added 2 commits September 17, 2025 12:28

try to fix module?

19e5b4d

fix module

c672434

Merge branch 'main' into updatejfx25

5808bef

koppor mentioned this pull request Sep 19, 2025

Enable Java EA builds and prepare JDK 26 #13937

Merged

3 tasks

fix: ThemeManager test

227ac76

koppor reviewed Sep 20, 2025

View reviewed changes

jabgui/src/main/java/org/jabref/gui/theme/ThemeManager.java Outdated Show resolved Hide resolved

Siedlerchr enabled auto-merge September 20, 2025 15:22

Siedlerchr disabled auto-merge September 21, 2025 16:47

Siedlerchr enabled auto-merge September 21, 2025 16:47

Siedlerchr added 2 commits September 21, 2025 19:03

more explanation and check if test is on fx thrad

a70facf

remove debug

8e076e7

koppor reviewed Sep 21, 2025

View reviewed changes

koppor approved these changes Sep 21, 2025

View reviewed changes

Siedlerchr added this pull request to the merge queue Sep 21, 2025

Merged via the queue into main with commit a0354bb Sep 21, 2025
56 checks passed

Siedlerchr deleted the updatejfx25 branch September 21, 2025 19:15

koppor mentioned this pull request Oct 1, 2025

Add more JBang tests #14010

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updatejfx25#13933

Updatejfx25#13933
Siedlerchr merged 24 commits intomainfrom
updatejfx25

Siedlerchr commented Sep 17, 2025 •

edited

Loading

Uh oh!

koppor commented Sep 17, 2025

Uh oh!

Siedlerchr commented Sep 17, 2025

Uh oh!

Siedlerchr commented Sep 17, 2025

Uh oh!

koppor commented Sep 19, 2025

Uh oh!

Uh oh!

trag-bot bot commented Sep 21, 2025

Uh oh!

koppor Sep 21, 2025

Uh oh!

Siedlerchr Sep 21, 2025

Uh oh!

trag-bot bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Siedlerchr commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

koppor commented Sep 17, 2025

Uh oh!

Siedlerchr commented Sep 17, 2025

Uh oh!

Siedlerchr commented Sep 17, 2025

Uh oh!

koppor commented Sep 19, 2025

Uh oh!

Uh oh!

trag-bot bot commented Sep 21, 2025

Uh oh!

koppor Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

trag-bot bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Siedlerchr commented Sep 17, 2025 •

edited

Loading