Clean up unused code in BibEntry class#14377
Merged
koppor merged 1 commit intoJabRef:mainfrom Nov 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing BibEntry, I noticed that two overloads of withSharedBibEntryData existed:
The second method contained a self-assignment bug (sharedBibEntryData = sharedBibEntryData;) and therefore did not update the field. After searching the codebase, I found that this method is not used anywhere.
What this PR does
Removes the unused and incorrect withSharedBibEntryData(SharedBibEntryData) method.
The reason to remove: Unused code increases complexity and makes future refactoring harder. Removing this also improves maintainability.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)