Skip to content

Conversation

@ennymojje
Copy link
Contributor

Closes #14249

This is a draft pull request which contains an additional button for filtering by date ranges in the search bar. The button works at the moment with a hard coded regular expression inside, so this still needs to be generalized. We have an idea on how to solve this, and will try to implement it.

Steps to test

To test this, press the button for date range (right now a placeholder with a check-mark) and type "[1111-11]-[1111-11]" in the search bar. It will then filter the results based on the hard coded "200[5-9]|201[0-9]".

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [] I added JUnit tests for changes (if applicable)
  • [] I added screenshots in the PR description (if change is visible to the user)
  • [] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@jabref-machine
Copy link
Collaborator

The title of the pull request must not start with "Fix for issue xyz". Please use a concise one-line summary that explains what the fix or change actually does. Example of a good title: "Prevent crash when importing malformed BibTeX entries".

@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

@jabref-machine
Copy link
Collaborator

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it.

In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 12, 2025
@calixtus
Copy link
Member

Im strongly against adding a new button to the search bar. This will be too crowded. You need to make an argument, why a button for filtering by date ranges must sit inside the search bar and why it is so special in contrast to a filter button for something else.

This needs a more general solution. See #8850

@calixtus
Copy link
Member

Please use a proper title for your PR. "Fix for issue xxx" is not acceptable.

@jabref-machine
Copy link
Collaborator

JUnit tests of jablib are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: search status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter entries down to certain date ranges

4 participants