Skip to content

Conversation

@pulkitbajaj
Copy link

@pulkitbajaj pulkitbajaj commented Dec 13, 2025

Closes #14497

Steps to test

  1. Download the JabRef.xml file provided in issue Import old jabref preferences fails with npe odel.metadata.UserHostInfo.getUserHostString #14497.
  2. Created a temporary JUnit test to reproduce the crash by calling new JabRefCliPreferences().getInternalPreferences().
  3. Verified that the test failed with a NullPointerException before the fix.
  4. Verified that the test passed successfully after applying the fix.

Mandatory checks


AI Disclosure: I used an AI assistant to help analyze the stack trace, understand the root cause (NullPointerException), and draft the reproduction test case. I manually verified the fix and the test results.

@github-actions
Copy link
Contributor

Hey @pulkitbajaj! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions bot added first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete labels Dec 13, 2025
@pulkitbajaj pulkitbajaj force-pushed the fix/import-preferences-npe branch from f3ea7aa to 8125a1d Compare December 13, 2025 18:35
@jabref-machine
Copy link
Collaborator

Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes.

When the pull request is getting integrated into main, all commits will be squashed anyway. Thus, your individual commit history will not be visible in main.

In future, please avoid that. For now, you can continue working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import old jabref preferences fails with npe odel.metadata.UserHostInfo.getUserHostString

2 participants