Skip to content

Fix: exception dialog shows up when moving sidepanel down/up #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calixtus merged 5 commits into from
Mar 2, 2026
Merged

Fix: exception dialog shows up when moving sidepanel down/up #15248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eebbf4a
fix exception dialog when moving panel down/up
pluto-han Mar 1, 2026
9881671
update CHANGELOG.md
pluto-han Mar 1, 2026
5cfd627
Apply suggestion from @Siedlerchr
pluto-han Mar 2, 2026
cc9386e
Stylistic change
calixtus Mar 2, 2026
7b927fe
Merge branch 'main' into fix-for-issue-15207
calixtus Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Fixed

- We fixed an issue where exception dialog will show up when moving side panels down/up. [#15207](https://github.com/JabRef/jabref/issues/15207)
Comment thread
pluto-han marked this conversation as resolved.
Outdated
- We fixed a false "Invalid citation key" warning for keys with diacritical marks. [#14953](https://github.com/JabRef/jabref/issues/14953)
- We fixed an issue where duplicate fields can be created. [#15130](https://github.com/JabRef/jabref/issues/15130)
- We fixed an issue where blank fields could be created. [#15130](https://github.com/JabRef/jabref/issues/15130)
Expand Down
10 changes: 8 additions & 2 deletions jabgui/src/main/java/org/jabref/gui/frame/SidePanePreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.jabref.gui.frame;

import java.util.EnumMap;
import java.util.EnumSet;
import java.util.Map;
import java.util.Set;
Expand All @@ -20,8 +21,13 @@ public class SidePanePreferences {
public SidePanePreferences(Set<SidePaneType> visiblePanes,
Map<SidePaneType, Integer> preferredPositions,
int webSearchFetcherSelected) {
this.visiblePanes = FXCollections.observableSet(visiblePanes);
this.preferredPositions = FXCollections.observableMap(preferredPositions);
EnumSet<SidePaneType> mutableVisiblePanes = EnumSet.noneOf(SidePaneType.class);
mutableVisiblePanes.addAll(visiblePanes);
EnumMap<SidePaneType, Integer> mutablePreferredPositions = new EnumMap<>(SidePaneType.class);
mutablePreferredPositions.putAll(preferredPositions);

this.visiblePanes = FXCollections.observableSet(mutableVisiblePanes);
this.preferredPositions = FXCollections.observableMap(mutablePreferredPositions);
this.webSearchFetcherSelected = new SimpleIntegerProperty(webSearchFetcherSelected);
}

Expand Down