Skip to content

fix(docs): change database to library in adr 0032#15482

Merged
calixtus merged 2 commits intoJabRef:mainfrom
InAnYan:fix/adr-lib-db
Apr 3, 2026
Merged

fix(docs): change database to library in adr 0032#15482
calixtus merged 2 commits intoJabRef:mainfrom
InAnYan:fix/adr-lib-db

Conversation

@InAnYan
Copy link
Copy Markdown
Member

@InAnYan InAnYan commented Apr 3, 2026

Related issues and pull requests

Closes _____

PR Description

Steps to test

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [.] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update ADR 0032 title: change "Database" to "Library"

📝 Documentation

Grey Divider

Walkthroughs

Description
• Updates ADR 0032 title to use "Library" instead of "Database"
• Aligns terminology with JabRef's preferred naming convention
Diagram
flowchart LR
  A["ADR 0032 Title"] -- "terminology update" --> B["Store Chats Alongside the Library"]
Loading

Grey Divider

File Changes

1. docs/decisions/0032-store-chats-in-local-user-folder.md 📝 Documentation +1/-1

Update ADR 0032 title terminology

• Changed title from "Store Chats Alongside Database" to "Store Chats Alongside the Library"
• Corrects terminology to align with JabRef's library naming convention

docs/decisions/0032-store-chats-in-local-user-folder.md


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

qodo-free-for-open-source-projects bot commented Apr 3, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX Issues (0)

Grey Divider


Remediation recommended

1. ADR title contradicts outcome🐞 Bug ⚙ Maintainability
Description
ADR 0032’s H1 says chats are stored alongside the library, but the Decision Outcome states the
chosen option is storing chats in the local user folder. This inconsistency can mislead readers
about the actual architectural decision recorded in the ADR.
Code

docs/decisions/0032-store-chats-in-local-user-folder.md[5]

+# Store Chats Alongside the Library
Evidence
The edited H1 communicates “alongside the library”, while the Decision Outcome section in the same
ADR documents the selected option as “In local user folder”, which describes a different storage
location than ‘alongside’ the library file.

docs/decisions/0032-store-chats-in-local-user-folder.md[5-5]
docs/decisions/0032-store-chats-in-local-user-folder.md[24-29]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
ADR-0032’s title indicates chats are stored alongside the library, but the ADR’s Decision Outcome states the chosen approach is storing chats in the local user folder. The title should match the actual recorded decision (or the decision text should be updated if the title is the intended decision).
## Issue Context
This PR already edits the H1, so it’s a good time to correct the remaining mismatch to avoid confusing future readers.
## Fix Focus Areas
- docs/decisions/0032-store-chats-in-local-user-folder.md[5-5]
- docs/decisions/0032-store-chats-in-local-user-folder.md[24-29]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@jabref-machine
Copy link
Copy Markdown
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of - [x] (done), - [ ] (yet to be done) or - [/] (not applicable). Please adhere to our pull request template.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Apr 3, 2026
Siedlerchr
Siedlerchr previously approved these changes Apr 3, 2026
@InAnYan
Copy link
Copy Markdown
Member Author

InAnYan commented Apr 3, 2026

wait wtf, the file name and title tell different things

@calixtus calixtus added this pull request to the merge queue Apr 3, 2026
@github-actions github-actions bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Apr 3, 2026
Merged via the queue into JabRef:main with commit b801295 Apr 3, 2026
55 checks passed
@InAnYan InAnYan deleted the fix/adr-lib-db branch April 15, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants