Add test case to FileHistoryTest

[HoussemNasri]

Related issues and pull requests

PR Description

Added test case.

Checklist

• I own the copyright of the code submitted and I license it under the MIT license
• I manually tested my changes in running JabRef (always required)
• I added JUnit tests for changes (if applicable)
• [/] I added screenshots in the PR description (if change is visible to the user)
• [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
• [/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
• I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Add test for file history size limit enforcement

🧪 Tests

Walkthroughs

Description

• Adds test verifying oldest entry removal when file history exceeds limit
• Tests that file history maintains maximum size of 8 entries
• Validates that newest file becomes first entry after overflow

Diagram

flowchart LR
  A["Add 8 files to history"] -- "size = 8" --> B["Add 9th file"]
  B -- "size stays 8" --> C["Verify oldest file dropped"]
  C -- "file9 at index 0" --> D["file1 no longer in history"]

Loading

File Changes

1. jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java 🧪 Tests +14/-0

Add file history size limit enforcement test

• Added new test method oldestEntryIsDroppedWhenSizeExceedsLimit()
• Tests that file history maintains maximum size of 8 entries
• Verifies oldest entry is removed when new file exceeds limit
• Confirms newest file becomes first entry in history

jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0)   📘 Rule violations (1)   📎 Requirement gaps (0)   🎨 UX Issues (0)

📘\ ≡ Correctness (1)

1. Weak contains() assertion 📘 ≡

Description

The new test uses assertFalse(history.contains(...)), which is a weak predicate check and does not
assert the exact expected history contents. This can miss regressions where the list content/order
is wrong but still does not contain that one element.

Code

jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java[83]

+        assertFalse(history.contains(Path.of("file1")));

Evidence

Compliance requires tests to assert exact expected values/structures and avoid weak predicate checks
like contains(...). The added assertion at line 83 is exactly such a weak predicate check.

AGENTS.md
jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java[83-83]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`oldestEntryIsDroppedWhenSizeExceedsLimit()` uses a weak predicate assertion (`assertFalse(history.contains(...))`) instead of asserting the exact expected contents/order of `history`.

## Issue Context
The project requires tests to assert exact expected values/structures and avoid predicate checks like `contains(...)` that can miss regressions.

## Fix Focus Areas
- jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java[72-84]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[qodo-free-for-open-source-projects]

1. Weak contains() assertion 📘 Rule violation ≡ Correctness

The new test uses assertFalse(history.contains(...)), which is a weak predicate check and does not
assert the exact expected history contents. This can miss regressions where the list content/order
is wrong but still does not contain that one element.

Agent Prompt

## Issue description
`oldestEntryIsDroppedWhenSizeExceedsLimit()` uses a weak predicate assertion (`assertFalse(history.contains(...))`) instead of asserting the exact expected contents/order of `history`.

## Issue Context
The project requires tests to assert exact expected values/structures and avoid predicate checks like `contains(...)` that can miss regressions.

## Fix Focus Areas
- jablib/src/test/java/org/jabref/logic/util/io/FileHistoryTest.java[72-84]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools