优化侧边栏和列表性能 #80

LanYun2022 · 2026-01-27T03:51:42Z

No description provided.

Copilot

Pull request overview

This PR optimizes the performance of the sidebar and list controls in the Context Menu Manager application by implementing asynchronous loading for shell items and refactoring the sidebar rendering approach.

Changes:

Implemented asynchronous loading for ShellList items using Task.Run with cancellation support
Added a new ShellItem constructor that accepts pre-computed data to avoid redundant registry reads
Refactored MySideBar rendering from panel-based to direct painting approach

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 40 comments.

File	Description
ContextMenuManager/MainForm.cs	Added ItemsLoaded event handler to coordinate search filtering with async list loading
ContextMenuManager/Controls/ShellList.cs	Implemented async loading with CancellationTokenSource, added helper methods to pre-compute item data, and introduced ItemsLoaded event
ContextMenuManager/Controls/ShellItem.cs	Added optimized constructor accepting pre-computed text, image, and multi-item flag to bypass expensive registry operations
ContextMenuManager/BluePointLilac.Controls/MySideBar.cs	Refactored from panel-based rendering to OnPaint-based approach, consolidated code, and abbreviated variable names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ContextMenuManager/Controls/ShellList.cs

Copilot · 2026-01-27T05:25:57Z

ContextMenuManager/Controls/ShellList.cs

+        private bool isMultiItem(string regPath) // helper
+        {
+             return GetIsMultiItem(regPath);
+        }
+


The helper method isMultiItem is redundant and adds no value - it simply calls GetIsMultiItem(regPath). This wrapper method should be removed and callers should directly use GetIsMultiItem instead. This eliminates unnecessary indirection and reduces maintainability burden.

Suggested change

private bool isMultiItem(string regPath) // helper

{

return GetIsMultiItem(regPath);

}

ContextMenuManager/BluePointLilac.Controls/MySideBar.cs

Copilot · 2026-01-27T05:25:57Z

ContextMenuManager/BluePointLilac.Controls/MySideBar.cs

+        private readonly Timer animTimer = new() { Interval = 16 };
        private string[] itemNames;
-        private int itemHeight = 36;
-        private int selectIndex = -1;
-        private int hoverIndex = -1;
-
-        private int animationTargetIndex = -1;
-        private int animationCurrentIndex = -1;
-        private float animationProgress = 0f;
-        private const float ANIMATION_SPEED = 0.25f;
+        private int itemHeight = 36, selectIndex = -1, hoverIndex = -1;
+        private int animTarget = -1, animCurrent = -1;
+        private float animProgress = 0f, curSelTop = -1;


Poor variable naming: Variable names have been excessively abbreviated (e.g., animTimer instead of animationTimer, animTarget/animCurrent instead of animationTargetIndex/animationCurrentIndex, curSelTop instead of currentSelectionTop). While shorter names can sometimes improve readability, these abbreviations make the code harder to understand, especially for developers unfamiliar with the codebase. The original names were clearer and self-documenting. Consider reverting to more descriptive names or at least using less cryptic abbreviations.

Copilot · 2026-01-27T05:25:57Z

ContextMenuManager/BluePointLilac.Controls/MySideBar.cs

+            void DrawItem(int idx, Color back, Color fore, float y)
            {
-                brush.InterpolationColors = new ColorBlend
+                if (idx < 0 || idx >= ItemNames.Length) return;
+                var r = new RectangleF(0, y, Width, ItemHeight);
+                if (back == Color.Transparent)
                {
-                    Colors = new[] { SelectedGradientColor1, SelectedGradientColor2, SelectedGradientColor3 },
-                    Positions = new[] { 0f, 0.5f, 1f }
-                };
-                e.Graphics.FillRectangle(brush, new Rectangle(0, 0, ctr.Width, ctr.Height));
+                    using var b = new LinearGradientBrush(r, Color.Empty, Color.Empty, 0f) { InterpolationColors = new ColorBlend { Colors = new[] { SelectedGradientColor1, SelectedGradientColor2, SelectedGradientColor3 }, Positions = new[] { 0f, 0.5f, 1f } } };
+                    e.Graphics.FillRectangle(b, r);
+                }
+                else { using var b = new SolidBrush(back); e.Graphics.FillRectangle(b, r); }
+                e.Graphics.SmoothingMode = SmoothingMode.AntiAlias; e.Graphics.TextRenderingHint = System.Drawing.Text.TextRenderingHint.ClearTypeGridFit;
+                using var fb = new SolidBrush(fore == Color.Empty ? ForeColor : fore);
+                e.Graphics.DrawString(ItemNames[idx], Font, fb, HorizontalSpace, y + vSpace);


Potential null reference exception: The local function DrawItem (line 155) doesn't check if ItemNames[idx] is null before using it in DrawString (line 167). While the callers at lines 170-171 should only pass valid indices, if ItemNames[idx] is null (which is used for separators elsewhere), this will throw an exception. Add a null check before drawing the string, or ensure the calling code never passes indices where ItemNames[idx] is null.

Copilot · 2026-01-27T05:26:04Z

ContextMenuManager/Controls/ShellList.cs

+                    icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -15);
            }
+            else if (hasLUAShield)
+                icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -78);
+            else 
+                icon = ResourceIcon.GetIcon(iconPath = itemFilePath, iconIndex = 0);
+
+            if (icon == null) 
+                icon = ResourceIcon.GetExtensionIcon(iconPath = itemFilePath) ?? ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -2);


This assignment to iconPath is useless, since its value is never read.

Suggested change

icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -15);

}

else if (hasLUAShield)

icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -78);

else

icon = ResourceIcon.GetIcon(iconPath = itemFilePath, iconIndex = 0);

if (icon == null)

icon = ResourceIcon.GetExtensionIcon(iconPath = itemFilePath) ?? ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -2);

icon = ResourceIcon.GetIcon("imageres.dll", iconIndex: -15);

}

else if (hasLUAShield)

icon = ResourceIcon.GetIcon("imageres.dll", iconIndex: -78);

else

icon = ResourceIcon.GetIcon(itemFilePath, iconIndex: 0);

if (icon == null)

icon = ResourceIcon.GetExtensionIcon(itemFilePath) ?? ResourceIcon.GetIcon("imageres.dll", iconIndex: -2);

Copilot · 2026-01-27T05:26:05Z

ContextMenuManager/Controls/ShellList.cs

+            else if (hasLUAShield)
+                icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -78);
+            else 
+                icon = ResourceIcon.GetIcon(iconPath = itemFilePath, iconIndex = 0);


This assignment to iconIndex is useless, since its value is never read.

Copilot · 2026-01-27T05:26:05Z

ContextMenuManager/Controls/ShellList.cs

+                    icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -15);
            }
+            else if (hasLUAShield)
+                icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -78);
+            else 
+                icon = ResourceIcon.GetIcon(iconPath = itemFilePath, iconIndex = 0);
+
+            if (icon == null) 
+                icon = ResourceIcon.GetExtensionIcon(iconPath = itemFilePath) ?? ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -2);


This assignment to iconPath is useless, since its value is never read.

Suggested change

icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -15);

}

else if (hasLUAShield)

icon = ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -78);

else

icon = ResourceIcon.GetIcon(iconPath = itemFilePath, iconIndex = 0);

if (icon == null)

icon = ResourceIcon.GetExtensionIcon(iconPath = itemFilePath) ?? ResourceIcon.GetIcon(iconPath = "imageres.dll", iconIndex = -2);

icon = ResourceIcon.GetIcon("imageres.dll", iconIndex: -15);

}

else if (hasLUAShield)

icon = ResourceIcon.GetIcon("imageres.dll", iconIndex: -78);

else

icon = ResourceIcon.GetIcon(itemFilePath, iconIndex: 0);

if (icon == null)

icon = ResourceIcon.GetExtensionIcon(itemFilePath) ?? ResourceIcon.GetIcon("imageres.dll", iconIndex: -2);

ContextMenuManager/Controls/ShellList.cs

Co-authored-by: Copilot <[email protected]>

优化侧边栏和列表性能

fd13b90

github-actions bot assigned LanYun2022 Jan 27, 2026

Jack251970 requested a review from Copilot January 27, 2026 05:18

Copilot started reviewing on behalf of Jack251970 January 27, 2026 05:18 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

LanYun2022 and others added 6 commits January 27, 2026 16:27

Update ContextMenuManager/Controls/ShellList.cs

dbbe2fa

Co-authored-by: Copilot <[email protected]>

Update ContextMenuManager/Controls/ShellList.cs

fae1184

Co-authored-by: Copilot <[email protected]>

Update ContextMenuManager/Controls/ShellList.cs

cc26bc4

Co-authored-by: Copilot <[email protected]>

Update ContextMenuManager/BluePointLilac.Controls/MySideBar.cs

66b5ed3

Co-authored-by: Copilot <[email protected]>

修复错误、优化代码、优化列表性能

d811f53

Merge branch 'master' into master

cf8b6a8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

优化侧边栏和列表性能 #80

优化侧边栏和列表性能 #80

Uh oh!

LanYun2022 commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

优化侧边栏和列表性能 #80

Are you sure you want to change the base?

优化侧边栏和列表性能 #80

Uh oh!

Conversation

LanYun2022 commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant