[#124]: Use tinygltf instead of assimp#125
Conversation
|
✅ WINDOWS COMPILE RESULT - SUCCESS! ✅ |
a11fd78 to
cb6576e
Compare
|
✅ UBUNTU COMPILE RESULT - SUCCESS! ✅ |
cb6576e to
60844c5
Compare
|
⚡ Static analysis result ⚡ 🔴 cppcheck found 10 issues! Click here to see details.Lines 40 to 45 in 8ea4c20 !Line: 40 - style: inconclusive: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const. [functionConst]
!Line: 36 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.
!Line: 40 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.Lines 36 to 41 in 8ea4c20 !Line: 36 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]
Lines 53 to 58 in 8ea4c20 !Line: 53 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]
Lines 64 to 69 in 8ea4c20 !Line: 64 - style: inconclusive: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const. [functionConst]
!Line: 382 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.
!Line: 64 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.Lines 67 to 72 in 8ea4c20 !Line: 67 - style: inconclusive: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const. [functionConst]
!Line: 326 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.
!Line: 67 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.Lines 60 to 65 in 8ea4c20 !Line: 60 - performance: Function 'GetName()' should return member 'm_name' by const reference. [returnByReference]
Lines 22 to 27 in 8ea4c20 !Line: 22 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Submit' can be const. [functionConst]
!Line: 24 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.
!Line: 22 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.Lines 25 to 30 in 8ea4c20 !Line: 25 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Draw' can be const. [functionConst]
!Line: 30 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.
!Line: 25 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.Lines 56 to 61 in 8ea4c20 !Line: 56 - style: inconclusive: Function 'LoadModel' argument 1 names different: declaration 'path' definition 'file'. [funcArgNamesDifferent]
!Line: 54 - note: Function 'LoadModel' argument 1 names different: declaration 'path' definition 'file'.
!Line: 56 - note: Function 'LoadModel' argument 1 names different: declaration 'path' definition 'file'.Lines 45 to 50 in 8ea4c20 !Line: 45 - style: inconclusive: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const. [functionConst]
!Line: 122 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.
!Line: 45 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.🔴 clang-tidy found 186 issues! Click here to see details.Lines 2 to 7 in 8ea4c20 !Line: 2 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]
Lines 4 to 9 in 8ea4c20 !Line: 4 - error: included header matrix_transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]
Lines 8 to 13 in 8ea4c20 !Line: 8 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 15 to 20 in 8ea4c20 !Line: 15 - error: no header providing "glm::ortho" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 15 to 20 in 8ea4c20 !Line: 15 - error: 200.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 15 to 20 in 8ea4c20 !Line: 15 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 15 to 20 in 8ea4c20 !Line: 15 - error: 500.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 22 to 27 in 8ea4c20 !Line: 22 - error: no header providing "glm::perspective" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 22 to 27 in 8ea4c20 !Line: 22 - error: 60.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 22 to 27 in 8ea4c20 !Line: 22 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 22 to 27 in 8ea4c20 !Line: 22 - error: 0.1f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 30 to 35 in 8ea4c20 !Line: 30 - error: no header providing "glm::translate" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 30 to 35 in 8ea4c20 !Line: 30 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 30 to 35 in 8ea4c20 !Line: 30 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 31 to 36 in 8ea4c20 !Line: 31 - error: no header providing "glm::scale" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 31 to 36 in 8ea4c20 !Line: 31 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 31 to 36 in 8ea4c20 !Line: 31 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 32 to 37 in 8ea4c20 !Line: 32 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 33 to 38 in 8ea4c20 !Line: 33 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Lines 33 to 38 in 8ea4c20 !Line: 33 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Lines 75 to 80 in 8ea4c20 !Line: 75 - error: no header providing "glm::tvec2" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 75 to 80 in 8ea4c20 !Line: 75 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]
Lines 93 to 98 in 8ea4c20 !Line: 93 - error: no header providing "glm::lookAt" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 4 to 9 in 8ea4c20 !Line: 4 - error: included header perspective_camera.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 11 to 16 in 8ea4c20 !Line: 11 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 12 to 17 in 8ea4c20 !Line: 12 - error: included header glm.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 13 to 18 in 8ea4c20 !Line: 13 - error: included header matrix_transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 18 to 23 in 8ea4c20 !Line: 18 - error: variable 'timer' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 18 to 23 in 8ea4c20 !Line: 18 - error: variable 'timer' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 18 to 23 in 8ea4c20 !Line: 18 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 20 to 25 in 8ea4c20 !Line: 20 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 21 to 26 in 8ea4c20 !Line: 21 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 25 to 30 in 8ea4c20 !Line: 25 - error: no header providing "glm::vec4" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 28 to 33 in 8ea4c20 !Line: 28 - error: no header providing "glm::mat4" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 42 to 47 in 8ea4c20 !Line: 42 - error: no header providing "shady::render::DebugData" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 45 to 50 in 8ea4c20 !Line: 45 - error: no header providing "VkDescriptorSet" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 51 to 56 in 8ea4c20 !Line: 51 - error: no header providing "VkPipeline" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 57 to 62 in 8ea4c20 !Line: 57 - error: no header providing "VkPipelineLayout" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 63 to 68 in 8ea4c20 !Line: 63 - error: no header providing "VkSemaphore" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 76 to 81 in 8ea4c20 !Line: 76 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 82 to 87 in 8ea4c20 !Line: 82 - error: no header providing "VkCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 94 to 99 in 8ea4c20 !Line: 94 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 96 to 101 in 8ea4c20 !Line: 96 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 98 to 103 in 8ea4c20 !Line: 98 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 101 to 106 in 8ea4c20 !Line: 101 - error: no header providing "memcpy" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 105 to 110 in 8ea4c20 !Line: 105 - error: no header providing "VkRenderPass" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 106 to 111 in 8ea4c20 !Line: 106 - error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 106 to 111 in 8ea4c20 !Line: 106 - error: no header providing "VkImageView" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 107 to 112 in 8ea4c20 !Line: 107 - error: no header providing "VkPipelineCache" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 130 to 135 in 8ea4c20 !Line: 130 - error: 4096 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 136 to 141 in 8ea4c20 !Line: 136 - error: 2048 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 138 to 143 in 8ea4c20 !Line: 138 - error: use designated initializer list to initialize 'VkExtent2D' [modernize-use-designated-initializers,-warnings-as-errors]
!Line: 3068 - note: aggregate type is defined hereShady/src/render/deferred_pipeline.cpp Lines 138 to 143 in 8ea4c20 !Line: 138 - error: 2048 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 146 to 151 in 8ea4c20 !Line: 146 - error: no header providing "VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 147 to 152 in 8ea4c20 !Line: 147 - error: no header providing "VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 147 to 152 in 8ea4c20 !Line: 147 - error: no header providing "VK_MEMORY_PROPERTY_HOST_COHERENT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 163 to 168 in 8ea4c20 !Line: 163 - error: no header providing "VkDescriptorSetLayoutBinding" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 166 to 171 in 8ea4c20 !Line: 166 - error: no header providing "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 168 to 173 in 8ea4c20 !Line: 168 - error: no header providing "VK_SHADER_STAGE_VERTEX_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 174 to 179 in 8ea4c20 !Line: 174 - error: no header providing "VK_DESCRIPTOR_TYPE_STORAGE_BUFFER" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 182 to 187 in 8ea4c20 !Line: 182 - error: no header providing "VK_DESCRIPTOR_TYPE_SAMPLER" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 184 to 189 in 8ea4c20 !Line: 184 - error: no header providing "VK_SHADER_STAGE_FRAGMENT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 189 to 194 in 8ea4c20 !Line: 189 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 190 to 195 in 8ea4c20 !Line: 190 - error: no header providing "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 198 to 203 in 8ea4c20 !Line: 198 - error: no header providing "VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 204 to 209 in 8ea4c20 !Line: 204 - error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 212 to 217 in 8ea4c20 !Line: 212 - error: 6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 220 to 225 in 8ea4c20 !Line: 220 - error: 7 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 228 to 233 in 8ea4c20 !Line: 228 - error: 8 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 234 to 239 in 8ea4c20 !Line: 234 - error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 234 to 239 in 8ea4c20 !Line: 234 - error: 9 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 239 to 244 in 8ea4c20 !Line: 239 - error: no header providing "VkDescriptorSetLayoutCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 240 to 245 in 8ea4c20 !Line: 240 - error: no header providing "VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 245 to 250 in 8ea4c20 !Line: 245 - error: no header providing "vkCreateDescriptorSetLayout" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 249 to 254 in 8ea4c20 !Line: 249 - error: no header providing "VkPipelineLayoutCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 250 to 255 in 8ea4c20 !Line: 250 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 254 to 259 in 8ea4c20 !Line: 254 - error: no header providing "vkCreatePipelineLayout" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 262 to 267 in 8ea4c20 !Line: 262 - error: no header providing "VkPipelineInputAssemblyStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 263 to 268 in 8ea4c20 !Line: 263 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 264 to 269 in 8ea4c20 !Line: 264 - error: no header providing "VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 265 to 270 in 8ea4c20 !Line: 265 - error: no header providing "VK_FALSE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 267 to 272 in 8ea4c20 !Line: 267 - error: no header providing "VkPipelineRasterizationStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 268 to 273 in 8ea4c20 !Line: 268 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 271 to 276 in 8ea4c20 !Line: 271 - error: no header providing "VK_POLYGON_MODE_FILL" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 272 to 277 in 8ea4c20 !Line: 272 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 274 to 279 in 8ea4c20 !Line: 274 - error: no header providing "VK_CULL_MODE_BACK_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 275 to 280 in 8ea4c20 !Line: 275 - error: no header providing "VK_FRONT_FACE_COUNTER_CLOCKWISE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 278 to 283 in 8ea4c20 !Line: 278 - error: no header providing "VkPipelineColorBlendAttachmentState" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 279 to 284 in 8ea4c20 !Line: 279 - error: 0xf is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 282 to 287 in 8ea4c20 !Line: 282 - error: no header providing "VkPipelineColorBlendStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 283 to 288 in 8ea4c20 !Line: 283 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 289 to 294 in 8ea4c20 !Line: 289 - error: no header providing "VkPipelineDepthStencilStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 290 to 295 in 8ea4c20 !Line: 290 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 291 to 296 in 8ea4c20 !Line: 291 - error: no header providing "VK_TRUE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 293 to 298 in 8ea4c20 !Line: 293 - error: no header providing "VK_COMPARE_OP_LESS_OR_EQUAL" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 295 to 300 in 8ea4c20 !Line: 295 - error: no header providing "VkPipelineViewportStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 296 to 301 in 8ea4c20 !Line: 296 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 300 to 305 in 8ea4c20 !Line: 300 - error: no header providing "VkPipelineMultisampleStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 301 to 306 in 8ea4c20 !Line: 301 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 302 to 307 in 8ea4c20 !Line: 302 - error: no header providing "VK_SAMPLE_COUNT_1_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 305 to 310 in 8ea4c20 !Line: 305 - error: no header providing "VkDynamicState" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 305 to 310 in 8ea4c20 !Line: 305 - error: no header providing "VK_DYNAMIC_STATE_VIEWPORT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 306 to 311 in 8ea4c20 !Line: 306 - error: no header providing "VK_DYNAMIC_STATE_SCISSOR" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 308 to 313 in 8ea4c20 !Line: 308 - error: no header providing "VkPipelineDynamicStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 309 to 314 in 8ea4c20 !Line: 309 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 315 to 320 in 8ea4c20 !Line: 315 - error: no header providing "VkPipelineShaderStageCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 319 to 324 in 8ea4c20 !Line: 319 - error: no header providing "VkSpecializationMapEntry" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 326 to 331 in 8ea4c20 !Line: 326 - error: no header providing "VkSpecializationInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 336 to 341 in 8ea4c20 !Line: 336 - error: no header providing "VkGraphicsPipelineCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 337 to 342 in 8ea4c20 !Line: 337 - error: no header providing "VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 351 to 356 in 8ea4c20 !Line: 351 - error: no header providing "VK_NULL_HANDLE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 354 to 359 in 8ea4c20 !Line: 354 - error: no header providing "VK_CULL_MODE_FRONT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 358 to 363 in 8ea4c20 !Line: 358 - error: no header providing "VkPipelineVertexInputStateCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 359 to 364 in 8ea4c20 !Line: 359 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 362 to 367 in 8ea4c20 !Line: 362 - error: no header providing "vkCreateGraphicsPipelines" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 387 to 392 in 8ea4c20 !Line: 387 - error: no header providing "VK_FRONT_FACE_CLOCKWISE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 390 to 395 in 8ea4c20 !Line: 390 - error: no header providing "std::tie" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 416 to 421 in 8ea4c20 !Line: 416 - error: no header providing "VK_COLOR_COMPONENT_R_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 416 to 421 in 8ea4c20 !Line: 416 - error: no header providing "VK_COLOR_COMPONENT_G_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 417 to 422 in 8ea4c20 !Line: 417 - error: no header providing "VK_COLOR_COMPONENT_B_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 417 to 422 in 8ea4c20 !Line: 417 - error: no header providing "VK_COLOR_COMPONENT_A_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 467 to 472 in 8ea4c20 !Line: 467 - error: no header providing "VK_DYNAMIC_STATE_DEPTH_BIAS" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 483 to 488 in 8ea4c20 !Line: 483 - error: no header providing "VkDescriptorPoolSize" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 483 to 488 in 8ea4c20 !Line: 483 - error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 485 to 490 in 8ea4c20 !Line: 485 - error: 8 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 487 to 492 in 8ea4c20 !Line: 487 - error: 9 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 496 to 501 in 8ea4c20 !Line: 496 - error: no header providing "VkDescriptorPoolCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 497 to 502 in 8ea4c20 !Line: 497 - error: no header providing "VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 502 to 507 in 8ea4c20 !Line: 502 - error: no header providing "vkCreateDescriptorPool" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 508 to 513 in 8ea4c20 !Line: 508 - error: no header providing "VkWriteDescriptorSet" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 508 to 513 in 8ea4c20 !Line: 508 - error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 510 to 515 in 8ea4c20 !Line: 510 - error: no header providing "VkDescriptorSetAllocateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 511 to 516 in 8ea4c20 !Line: 511 - error: no header providing "VK_STRUCTURE_TYPE_DESCRIPTOR_SET_ALLOCATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 517 to 522 in 8ea4c20 !Line: 517 - error: no header providing "VkDescriptorImageInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 518 to 523 in 8ea4c20 !Line: 518 - error: no header providing "VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 533 to 538 in 8ea4c20 !Line: 533 - error: no header providing "VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 538 to 543 in 8ea4c20 !Line: 538 - error: no header providing "vkAllocateDescriptorSets" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 541 to 546 in 8ea4c20 !Line: 541 - error: no header providing "VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 543 to 548 in 8ea4c20 !Line: 543 - error: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 552 to 557 in 8ea4c20 !Line: 552 - error: 6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 570 to 575 in 8ea4c20 !Line: 570 - error: 7 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 579 to 584 in 8ea4c20 !Line: 579 - error: 8 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 585 to 590 in 8ea4c20 !Line: 585 - error: no header providing "vkUpdateDescriptorSets" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 591 to 596 in 8ea4c20 !Line: 591 - error: no header providing "shady::render::TextureType" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 593 to 598 in 8ea4c20 !Line: 593 - error: no header providing "VkDescriptorBufferInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 596 to 601 in 8ea4c20 !Line: 596 - error: no header providing "shady::render::UniformBufferObject" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 602 to 607 in 8ea4c20 !Line: 602 - error: no header providing "shady::render::PerInstanceBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 606 to 611 in 8ea4c20 !Line: 606 - error: use a boost version of this algorithm [boost-use-ranges,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 606 to 611 in 8ea4c20 !Line: 606 - error: use a ranges version of this algorithm [modernize-use-ranges,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 662 to 667 in 8ea4c20 !Line: 662 - error: no header providing "VkCommandBufferAllocateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 663 to 668 in 8ea4c20 !Line: 663 - error: no header providing "VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 664 to 669 in 8ea4c20 !Line: 664 - error: no header providing "VK_COMMAND_BUFFER_LEVEL_PRIMARY" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 668 to 673 in 8ea4c20 !Line: 668 - error: no header providing "vkAllocateCommandBuffers" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 673 to 678 in 8ea4c20 !Line: 673 - error: no header providing "VkSemaphoreCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 674 to 679 in 8ea4c20 !Line: 674 - error: no header providing "VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 677 to 682 in 8ea4c20 !Line: 677 - error: no header providing "vkCreateSemaphore" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 679 to 684 in 8ea4c20 !Line: 679 - error: no header providing "VkCommandBufferBeginInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 680 to 685 in 8ea4c20 !Line: 680 - error: no header providing "VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 683 to 688 in 8ea4c20 !Line: 683 - error: no header providing "VkClearValue" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 685 to 690 in 8ea4c20 !Line: 685 - error: no header providing "VkRenderPassBeginInfo" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 686 to 691 in 8ea4c20 !Line: 686 - error: no header providing "VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 690 to 695 in 8ea4c20 !Line: 690 - error: use designated initializer list to initialize 'VkClearDepthStencilValue' [modernize-use-designated-initializers,-warnings-as-errors]
!Line: 4138 - note: aggregate type is defined hereShady/src/render/deferred_pipeline.cpp Lines 690 to 695 in 8ea4c20 !Line: 690 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 699 to 704 in 8ea4c20 !Line: 699 - error: no header providing "vkBeginCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 701 to 706 in 8ea4c20 !Line: 701 - error: no header providing "VkViewport" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 704 to 709 in 8ea4c20 !Line: 704 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 705 to 710 in 8ea4c20 !Line: 705 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 707 to 712 in 8ea4c20 !Line: 707 - error: no header providing "vkCmdSetViewport" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 715 to 720 in 8ea4c20 !Line: 715 - error: no header providing "vkCmdSetScissor" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 718 to 723 in 8ea4c20 !Line: 718 - error: no header providing "vkCmdSetDepthBias" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 718 to 723 in 8ea4c20 !Line: 718 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 720 to 725 in 8ea4c20 !Line: 720 - error: no header providing "vkCmdBeginRenderPass" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 720 to 725 in 8ea4c20 !Line: 720 - error: no header providing "VK_SUBPASS_CONTENTS_INLINE" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 721 to 726 in 8ea4c20 !Line: 721 - error: no header providing "vkCmdBindPipeline" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 721 to 726 in 8ea4c20 !Line: 721 - error: no header providing "VK_PIPELINE_BIND_POINT_GRAPHICS" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 725 to 730 in 8ea4c20 !Line: 725 - error: no header providing "VkDeviceSize" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 726 to 731 in 8ea4c20 !Line: 726 - error: no header providing "vkCmdBindVertexBuffers" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 728 to 733 in 8ea4c20 !Line: 728 - error: no header providing "vkCmdBindIndexBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 728 to 733 in 8ea4c20 !Line: 728 - error: no header providing "VK_INDEX_TYPE_UINT32" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 730 to 735 in 8ea4c20 !Line: 730 - error: no header providing "vkCmdBindDescriptorSets" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 734 to 739 in 8ea4c20 !Line: 734 - error: no header providing "vkCmdDrawIndexedIndirectCount" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 736 to 741 in 8ea4c20 !Line: 736 - error: no header providing "VkDrawIndexedIndirectCommand" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 740 to 745 in 8ea4c20 !Line: 740 - error: no header providing "vkCmdEndRenderPass" is directly included [misc-include-cleaner,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 745 to 750 in 8ea4c20 !Line: 745 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 746 to 751 in 8ea4c20 !Line: 746 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
Shady/src/render/deferred_pipeline.cpp Lines 747 to 752 in 8ea4c20 !Line: 747 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]
!Maximum character count per GitHub comment has been reached! Not all warnings/errors has been parsed! |
1694522 to
6fe4a8e
Compare
780ec6d to
08351b1
Compare
Fixes #124