Skip to content

Allow emojis and accented characters in names and locations. - #282

Open
ra314 wants to merge 1 commit into
JacobEvelyn:mainfrom
ra314:fix/emoji-name-support
Open

Allow emojis and accented characters in names and locations.#282
ra314 wants to merge 1 commit into
JacobEvelyn:mainfrom
ra314:fix/emoji-name-support

Conversation

@ra314

@ra314 ra314 commented Apr 13, 2026

Copy link
Copy Markdown

Updated the regex in Event to use Unicode properties (\p{L}, \p{N}, \p{S}). This allows names and locations to start with emojis or accented letters. Added unit tests for emoji and accented name validation.


Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • [✓] The code in these changes works correctly.
  • [✓] Code has tests as appropriate.
  • [ x] Code has been reviewed by @JacobEvelyn.
  • [ x] All tests pass on GitHub.
  • [✓] Code coverage remains high.
  • [✓] RuboCop reports no issues on GitHub.
  • [ x] The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!


I ran the following and there were no issues.

bundle exec rubocop lib/friends/event.rb
bundle exec rake test

I also added unit tests to cover names that start with emoji.

Updated the regex in Event to use Unicode properties (\p{L}, \p{N}, \p{S}).
This allows names and locations to start with emojis or accented letters.
Added unit tests for emoji and accented name validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant