Skip to content

Update from .net8 to .net10 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jake-Derrick merged 8 commits into from
Dec 31, 2025
Merged

Update from .net8 to .net10 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
41b8c41
Update from .net8 to .net10. Update github workflows
Dec 31, 2025
2613b71
update solution path
Dec 31, 2025
355e45a
add RestorePackagesWithLockFile
Dec 31, 2025
5effdcd
remove packages lock
Dec 31, 2025
2032793
upate to ci to csproj
Dec 31, 2025
a3b86a3
remove cache
Dec 31, 2025
09adcbc
split ios and android CI
Dec 31, 2025
ca297da
get rid of the hoe
Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/workflows/ci-sample.yml
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions .github/workflows/ci.yml
View file
Open in desktop

This file was deleted.

14 changes: 6 additions & 8 deletions .github/workflows/release-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ on:
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
- "v[0-9]+.[0-9]+.[0-9]+-preview[0-9]+"

jobs:
release-nuget:

runs-on: windows-latest
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
Expand All @@ -19,11 +19,9 @@ jobs:
- name: Get version information from tag
id: get_version
run: |
$version="${{github.ref_name}}".TrimStart("v")
"version-without-v=$version" | Out-File -FilePath $env:GITHUB_OUTPUT -Append
version="${GITHUB_REF_NAME#v}"
echo "version-without-v=$version" >> $GITHUB_OUTPUT
- name: Pack
run: dotnet pack src\Plugin.Maui.OtpReader.sln -c Release -p:PackageVersion=${{ steps.get_version.outputs.version-without-v }}
run: dotnet pack src/Plugin.Maui.OtpReader/Plugin.Maui.OtpReader.csproj -c Release -p:PackageVersion=${{ steps.get_version.outputs.version-without-v }}
- name: Push
run: dotnet nuget push src\Plugin.Maui.OtpReader\bin\Release\Plugin.Maui.OtpReader.${{ steps.get_version.outputs.version-without-v }}.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_API_KEY }}
env:
GITHUB_TOKEN: ${{ secrets.NUGET_API_KEY }}
run: dotnet nuget push src/Plugin.Maui.OtpReader/bin/Release/Plugin.Maui.OtpReader.${{ steps.get_version.outputs.version-without-v }}.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_API_KEY }}
0 src/Plugin.Maui.OtpReader/nuget.png → icon.png
View file
Open in desktop
File renamed without changes
Binary file removed nuget.png
View file
Open in desktop
Binary file not shown.
9 changes: 5 additions & 4 deletions samples/Plugin.Maui.OtpReader.Sample/Plugin.Maui.OtpReader.Sample.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0-android;net8.0-ios;net8.0-maccatalyst</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks>
<TargetFrameworks>net10.0-android;net10.0-ios;net10.0-maccatalyst</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net10.0-windows10.0.19041.0</TargetFrameworks>
<!-- Uncomment to also build the tizen app. You will need to install tizen by following this: https://github.com/Samsung/Tizen.NET -->
<!-- <TargetFrameworks>$(TargetFrameworks);net8.0-tizen</TargetFrameworks> -->
<!-- <TargetFrameworks>$(TargetFrameworks);net10.0-tizen</TargetFrameworks> -->
<OutputType>Exe</OutputType>
<RootNamespace>Plugin.Maui.OtpReader.Sample</RootNamespace>
<UseMaui>true</UseMaui>
<SingleProject>true</SingleProject>
<ImplicitUsings>enable</ImplicitUsings>
<RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>

<!-- Display name -->
<ApplicationTitle>OtpReader Sample</ApplicationTitle>
Expand Down Expand Up @@ -50,6 +51,6 @@

<ItemGroup>
<ProjectReference Include="..\..\src\Plugin.Maui.OtpReader\Plugin.Maui.OtpReader.csproj" />
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
<PackageReference Include="Microsoft.Maui.Controls" Version="10.0.20" />
</ItemGroup>
</Project>
19 changes: 11 additions & 8 deletions src/Plugin.Maui.OtpReader/Plugin.Maui.OtpReader.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net8.0-android;net8.0-ios;net8.0-maccatalyst;net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks>
<TargetFrameworks>net10.0-android;net10.0-ios;net10.0-maccatalyst;net10.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net10.0-windows10.0.19041.0</TargetFrameworks>
<SingleProject>true</SingleProject>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<UseMaui>true</UseMaui>

<RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>

<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">14.2</SupportedOSPlatformVersion>
<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'maccatalyst'">14.0</SupportedOSPlatformVersion>
<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">21.0</SupportedOSPlatformVersion>
Expand Down Expand Up @@ -62,21 +63,23 @@
</ItemGroup>
<!-- .NET (generic) -->
<ItemGroup Condition="!($(TargetFramework.StartsWith('net')) == true AND $(TargetFramework.EndsWith('.0')) == true AND $(TargetFramework.Contains('-')) != true)">
<!-- e.g net6.0 or net8.0 (and higher) -->
<!-- e.g net6.0 or net10.0 (and higher) -->
<Compile Remove="**\*.net.cs" />
<None Include="**\*.net.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
</ItemGroup>

<!-- Package additions -->
<ItemGroup>
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
<None Include="..\..\icon.png" Pack="true" PackagePath="\" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
<PackageReference Include="Microsoft.Maui.Controls" Version="10.0.20" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="all" IsImplicitlyDefined="true" />
<PackageReference Include="System.Management" Version="7.0.0" Condition="$(TargetFramework.Contains('-windows')) == true" />
<PackageReference Include="Xamarin.GooglePlayServices.Auth" Version="121.1.1" Condition="$(TargetFramework.Contains('-android')) == true" />
<PackageReference Include="Xamarin.AndroidX.Fragment.Ktx" Version="1.7.0.2" Condition="$(TargetFramework.Contains('-android')) == true" />
<PackageReference Include="System.Management" Version="10.0.1" Condition="$(TargetFramework.Contains('-windows')) == true" />
<PackageReference Include="Xamarin.GooglePlayServices.Auth" Version="121.4.0.1" Condition="$(TargetFramework.Contains('-android')) == true" />
<PackageReference Include="Xamarin.AndroidX.Fragment.Ktx" Version="1.8.9" Condition="$(TargetFramework.Contains('-android')) == true" />
</ItemGroup>

</Project>