Layout update deadlock fix #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a deadlock situation when a client (ahem, vlc) sends far too many layout updates in a tiny time window.
JakeStanger
force-pushed
the
fix/layout-update
branch
from
e6bcce2 to
80fac4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things and makes a few code improvements. Most importantly, this fixes a long-standing bug with the
dbusmenuimplementation where some clients could send an update and cause the client to hang:VLC (the known example) has a habit of sending a burst of 100+ layout updates within a 30ms timeframe, which exceeds the Tokio/zbus throughput. It's hard to say what happened exactly, but my guess is that some internal mutex got overwhelmed and deadlocked.
The fix is to debounce the events, ie only process the last one within a timeframe. This does add a small (50ms) processing delay but ensures the events get where they're supposed to go.