-
Notifications
You must be signed in to change notification settings - Fork 17
Multiple patches #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Multiple patches #25
Conversation
I added Travis continuous integration for automatically pushing changes to the documentation. It hadn't been updated for years and it's a pain to do it manually. Another upside is that if a test-suite of some kind is added, it will be trivial to integrate it with Travis. Anyway, what do you want me to do about the recent PRs? Do you want to merge just this big one when it's all ready? Just ping me whenever. |
@JakobOvrum: Nice to see you again. :-) conn:send("PRIVMSG %s :%s", target, text)
-- New way:
conn:queue(irc.msgs.privmsg(target, text))
-- Or:
conn:queue(irc.Message("PRIVMSG", {target, text})) This allows for easy future extension to other IRC protocols, such as a JSON-based one. Once this is merged I'll close my other pulls (or you can). I checked your commits and noticed that they hardcode the owner and reop names. I find luadoc hard to use, but maybe a little reading will help... Also: Is there a IRC network that you frequent? Or at least some communication method more appropriate than GitHub issues? I'd like to be able to disscuss things more real-time. |
The
It has all the problems I mentioned in the other PR. Only messages that are triggered by the user should be queued, and even then it must be optional.
That's intentional. The encrypted Github access token in LuaDoc is a bit of a pain, but now that there are scripts that are run automatically, developers won't have to touch it unless it's a fork they don't intend to push upstream to JakobOvrum/LuaIRC (and in that case, the scripts show how it's done anyway).
I'm |
BTW, didn't we talk about this before? The user can easily refer to the connection as an upvalue in the callback function. |
It is of course possible to get the connection by wrapping every hook and a wrapper for every connection, like I do here. But passing it from the library would be much cleaner. |
The only strange thing was how init.lua has async.lua fill in the metatable.
Conflicts: handlers.lua
4324f56
to
e49a52e
Compare
This combines a number of my pull requests and future commits will be added to it to prevent flooding the issue list.
To do: