Adjust to upcoming Julia 1.12 change in implicit world age increment#40
Open
Keno wants to merge 1 commit intoJamieMair:mainfrom
Open
Adjust to upcoming Julia 1.12 change in implicit world age increment#40Keno wants to merge 1 commit intoJamieMair:mainfrom
Keno wants to merge 1 commit intoJamieMair:mainfrom
Conversation
In 1.12, we'll be cleaning up and making consistent when world age increment happens. This package is currently relying on implicit world age increments that may go away in 1.12. See JuliaLang/julia#56509. This PR adds appropriate annotations that the world age increment is required after the include. This PR strictly retains existing behavior. A potentially better solution may be to use invokelatest and/or move more work out of the macro, which would also allow this code to work at non-toplevel (which may nor may not be desirable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.12, we'll be cleaning up and making consistent when world age increment happens. This package is currently relying on implicit world age increments that may go away in 1.12. See JuliaLang/julia#56509. This PR adds appropriate annotations that the world age increment is required after the include. This PR strictly retains existing behavior. A potentially better solution may be to use invokelatest and/or move more work out of the macro, which would also allow this code to work at non-toplevel (which may nor may not be desirable).