Skip to content

fix(types): allow additional properties on customTypes#255

Closed
chase-tamnoon wants to merge 1 commit intoJamieMason:mainfrom
chase-tamnoon:patch-1
Closed

fix(types): allow additional properties on customTypes#255
chase-tamnoon wants to merge 1 commit intoJamieMason:mainfrom
chase-tamnoon:patch-1

Conversation

@chase-tamnoon
Copy link
Contributor

@chase-tamnoon chase-tamnoon commented Dec 26, 2024

Description (What)

diff of generated json schema
image
image

Justification (Why)

can't use customTypes with json schema

How Can This Be Tested?

Run pnpm run build:json-schema and compare dist/schema.json

@JamieMason
Copy link
Owner

Sorry @chase-tamnoon I missed this, thanks a lot I'll get it merged soon.

@JamieMason JamieMason changed the title Change type so the generated json schema for property "customTypes" allows additional properties of a certain type fix(types): allow additional properties on customTypes Jan 22, 2025
@JamieMason JamieMason closed this in 06e6a04 Feb 2, 2025
@JamieMason
Copy link
Owner

(finally) released in 13.0.1, thanks @chase-tamnoon

JamieMason added a commit that referenced this pull request Feb 5, 2025
JamieMason added a commit that referenced this pull request Feb 5, 2025
JamieMason added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments