Allow PHPUnit 12 #364
Allow PHPUnit 12 #364
Conversation
Jean85
force-pushed
the
phpunit-12-support
branch
from
dc413f5 to
0a6b630
Compare
| @@ -16,7 +16,7 @@ | |||
| "conflict": { | |||
| "phpspec/prophecy": "<1.17.0 || >=2.0.0", | |||
| "phpspec/prophecy-phpunit": "<2.3.0 || >=3.0.0", | |||
| "phpunit/phpunit": "<9.1.0 || >=12.0.0" | |||
| "phpunit/phpunit": "<9.1.0 || >=13.0.0" | |||
There was a problem hiding this comment.
requires: phpspec/prophecy-phpunit#67
… to unlock PHPUnit 12 See Jan0707/phpstan-prophecy#364 and phpspec/prophecy-phpunit#67
|
Static analysis is failing due to Tests are running only on PHPUnit 9 though :( we should change that |
… to unlock PHPUnit 12 See Jan0707/phpstan-prophecy#364 and phpspec/prophecy-phpunit#67
Jean85
force-pushed
the
phpunit-12-support
branch
from
0a6b630 to
eaf5cf4
Compare
|
looks like we need to wait for the |
|
@alexander-schranz since it's a require-dev, I took the liberty of adding a workaround for this. Are you ok with merging it in this way? |
Jean85
force-pushed
the
phpunit-12-support
branch
from
959ec39 to
6b8dd07
Compare
Jean85
force-pushed
the
phpunit-12-support
branch
from
6b8dd07 to
5f940fa
Compare
|
@Jean85 I'm fine to merge it but not tag it would before tagging revert the master and specially reactivate composer strict linting, when phpunity-prophecy is tagged. Can you open a PR with reverting that parts? |
|
@alexander-schranz done in #386 |
| @@ -18,13 +18,13 @@ | |||
| "ergebnis/license": "^2.6.0", | |||
| "ergebnis/php-cs-fixer-config": "^6.46.0", | |||
| "phpspec/prophecy": "^1.7.0", | |||
| "phpspec/prophecy-phpunit": "^2.3", | |||
| "phpspec/prophecy-phpunit": "^2.3 || dev-master#d3c2804 as 2.4.0", | |||
There was a problem hiding this comment.
A simpler workaround would have been ^2.3@dev, as phpstan-prophecy has the proper branch alias for its master branch (and the commit hash lock is a very bad idea due to how this actually works in composer)
This pull request
This is a tentative PR to see if we can just widen the constraint, or if we need to do more work.