Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add securityContext & remove allowPrerelease from winget config #6291

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

mdanish-kh
Copy link
Contributor

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

Microsoft.WinGet.DSC/WinGetPackage is GA now so allowPrerelease: true directive can be removed. Also, installing NodeJS requires admin privileges, added securityContext: elevated for that resource. What this directive does is that it will prompt for a single UAC at the start of the configuration and then launch two separated process - one elevated & one with current privileges. The resources that require elevation will be run in the elevated process

@denelon
Copy link
Contributor

denelon commented Mar 19, 2025

Thanks @mdanish-kh for helping improve "configuration as code" 👍

@JanDeDobbeleer JanDeDobbeleer merged commit b2962e4 into JanDeDobbeleer:main Mar 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants