Add Power/Jet fan speed (fan value 7) as CLIMATE_FAN_FOCUS - #188
Open
jkosharek wants to merge 1 commit into
Open
Add Power/Jet fan speed (fan value 7) as CLIMATE_FAN_FOCUS#188jkosharek wants to merge 1 commit into
jkosharek wants to merge 1 commit into
Conversation
|
Great addition! Thinking out loud: Do we know the protocol of the LG Thinq wifi module? Perhaps we can find some logic/similarities in the protocol to map the missing fan speeds. protocol.md already contains the other fan speeds. I don't know where this is taken from, but my LG ignores 5 and 6. Fan speed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…yte 3 bit 0x02
This adds support for the Power fan speed (Jet Cool / Jet Mode on LG remotes and ThinQ), which the protocol carries as fan speed 7 in the type 0 status message.
Verified on the wire (LG RAC_056905_WW wall unit): enabling Jet Cool from the ThinQ app makes the unit send
C8.E3.40.00.00.04.03.66...- byte 1 = 0xE3 (fan bits = 7), byte 6 = 0x03 (the unit also self-drops the setpoint to 18C). Before this patch the controller loggedreceived unexpected fan mode from AC (7), rejected the message, and as master then reverted the AC back to the previous fan speed within one status cycle.Changes (all in lg-controller.h):
FAN_POWERadded toLgCapability, gated on the capabilities message byte 3 bit 0x02 ("Supports fan speed Power")CLIMATE_FAN_FOCUS(shows as "Focus" in HA), matching how other components expose turbo fanCLIMATE_FAN_FOCUS-> fan bits 7; RX: fan value 7 ->CLIMATE_FAN_FOCUSTested: setting Focus from HA engages Power Cool on the unit (and the unit self-drops its setpoint to 18C, same as the app path); enabling Jet Cool from the ThinQ app is now tracked instead of rejected/reverted. Fan values 5/6 (low-medium / medium-high) are still unmapped - happy to add those too if you have a preferred mapping.
Bonus YAML for others (no code changes needed - sharing since it pairs well with this):
A ThinQ-style Power Cool on/off switch (saves the setpoint on turn-on, restores it on turn-off since the unit strands it at 18C). Requires a
globalsfloatpre_power_cool_targetwithrestore_value: yes:And a smartthinq-style single "Vertical Swing" dropdown merging vane 1 position with the vertical sweep flag (for single-vane wall units; assumes the vane1 select has
id: vane_position_1):(A matching "Swing - Horizontal" Off/Swing select is trivial the same way - the wired protocol only carries a horizontal sweep bit, no fixed horizontal positions.)