Add templates for presentation viewer#111
Conversation
bece4c8 to
c0a313d
Compare
09ccaa1 to
4fc196c
Compare
4fc196c to
ec7b7e6
Compare
4040b87 to
72d5434
Compare
e41f8d3 to
004f603
Compare
004f603 to
306f108
Compare
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
a908873 to
f25b932
Compare
|
pnpm update and then make command did not help |
|
Can you do |
|
|
individual-it
left a comment
There was a problem hiding this comment.
would be good to have a "blank" template that works just as the default reveal-js template
| footer: <footer-content> | ||
| aboutUs: | ||
| - title: <about-us-title1> | ||
| text: <text-for-title1> |
There was a problem hiding this comment.
how difficult would it be to allow links here?
Currently
- title: WWW
text: [www.jankaritech.com](www.jankaritech.com)
makes the whole presentation to fall apart
Object { name: "YAMLException", reason: "bad indentation of a mapping entry", mark: {…}, message: "bad indentation of a mapping entry at line 7, column 10:\n text: [www.jankaritech.com](www.jank ... \n ^", stack: "", … }
mark: Object { buffer: "slide: title-content\npresenter: JankariTech Pvt. Ltd. \nlogo: Logo-colour.png\nfooter: Markdown Presentation Viewer\naboutUs:\n - title: WWW\n text: [www.jankaritech.com](www.jankaritech.com)\n - title: linkedin\n text: www.linkedin.com/company/jankaritech\n - title: facebook\n text: www.facebook.com/jankaritech\n\u0000", position: 148, line: 6, … }
message: "bad indentation of a mapping entry at line 7, column 10:\n text: [www.jankaritech.com](www.jank ... \n ^"
name: "YAMLException"
reason: "bad indentation of a mapping entry"
If links are not supported that is fine, but the presentation should not break
There was a problem hiding this comment.
Doing something invalid here, e.g text:www.jankaritech.com leads now to this error:
YAMLException: can not read an implicit mapping pair; a colon is missed at line 7, column 29: text:www.jankaritech.com ^
it gives some hint, but might still be hard for users to understand. Do we want to accept that kind of error message for now?
|
Let's add tests for the templating to make sure all these corner cases don't break |
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
|
I have addressed the issues and fixed them. Most of the fixes needed to done in the plugin (PR: opf/revealjs-awesoMD#24).
Will work on it. 👍 |
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
fa7702c to
7ee9e83
Compare
7ee9e83 to
80441ef
Compare
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
individual-it
left a comment
There was a problem hiding this comment.
anything shown to the user e.g. error messages should be sanitized.
currently I can do:
# This template does not exist and has special char ::slide:<a href="jankari.tech">jankaritech</a>
and the browser will render <a href="jankari.tech">jankaritech</a> as HTML
There was a problem hiding this comment.
sometimes the logo works sometimes not
I am using
---
slide: title-content
presenter: JankariTech Pvt. Ltd.
logo: images/Logo-colour.png
and the file images/Logo-colour.png does exist.
the URL of the logo in the presentation is sometimes: https://localhost:9200/images/Logo-colour.png but after a reload correctly blob:https://localhost:9200/9db3f52b-2d67-4be4-b116-9a94f6798c7
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
Fixed it in PR opf/revealjs-awesoMD#25. The fix for this is in PR opf/revealjs-awesoMD#25. |
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>
Signed-off-by: Prajwol Amatya <prajwolamatya11@gmail.com>



Description
This PR adds basic templates for the presentation viewer.
Following templates are added:
Slide content fitting
The font size of the slide will be automatically reduced when the content tends to overflow out of the slide.