Skip to content

Conversation

@iromli
Copy link
Contributor

@iromli iromli commented Feb 7, 2026

Prepare


Description

Target issue

closes #13074

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Summary by CodeRabbit

  • New Features

    • Added Shibboleth Identity Provider integration for identity management.
  • Documentation

    • Updated configuration docs and plugin listings to remove SAML entries and reflect new Shibboleth support.
    • Removed several Keycloak DB-related configuration entries from the values documentation.
  • Chores

    • Migrated container image repositories to the GitHub Container Registry and updated relevant default image tags.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli self-assigned this Feb 7, 2026
@iromli iromli requested a review from moabu as a code owner February 7, 2026 21:28
@mo-auto
Copy link
Member

mo-auto commented Feb 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Migrates many Janssen sub-chart image.repository values to ghcr.io and replaces top-level kc-scheduler/saml entries with a new shibboleth-idp configuration in the main chart, adding the shibboleth-idp chart and updating related README/values defaults.

Changes

Cohort / File(s) Summary
Main Janssen Chart
charts/janssen/README.md
Removes kc-scheduler and saml blocks from global/config sections and adds shibboleth-idp entries, appLoggers, customAnnotations, ingress, enabled flags, and updates config-api.plugins docs.
Shibboleth-idp Chart
charts/janssen/charts/shibboleth-idp/README.md, charts/janssen/charts/shibboleth-idp/values.yaml
Adds shibboleth-idp chart; updates image.repository to ghcr.io/janssenproject/jans/shibboleth and image.tag to 0.0.0-nightly.
Config Chart
charts/janssen/charts/config/README.md, charts/janssen/charts/config/values.yaml
Removes Keycloak DB-related Values entries from README and updates configurator image.repository to ghcr.io/janssenproject/jans/configurator.
Image registry updates (multiple sub-charts)
charts/janssen/charts/auth-server-key-rotation/README.md, charts/janssen/charts/auth-server-key-rotation/values.yaml, charts/janssen/charts/auth-server/README.md, charts/janssen/charts/auth-server/values.yaml, charts/janssen/charts/casa/README.md, charts/janssen/charts/casa/values.yaml, charts/janssen/charts/config-api/README.md, charts/janssen/charts/config-api/values.yaml, charts/janssen/charts/fido2/README.md, charts/janssen/charts/fido2/values.yaml, charts/janssen/charts/persistence/README.md, charts/janssen/charts/persistence/values.yaml, charts/janssen/charts/scim/README.md, charts/janssen/charts/scim/values.yaml
Repoints many sub-chart image.repository values from janssenproject/... to ghcr.io/janssenproject/jans/... (README and values.yaml updates).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • iromli
  • misba7
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes out-of-scope changes not mentioned in issue #13074: removing kc-scheduler and saml blocks from main values.yaml, adding shibboleth-idp configuration, and removing Keycloak database configuration from charts/janssen/charts/config. Remove changes unrelated to image repository URL updates. Either address those changes separately or document them in a new issue and PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely summarizes the main change: updating image repository URLs from docker.io to ghcr.io across multiple sub-charts.
Description check ✅ Passed The PR description includes the required template sections with the target issue (#13074) specified, implementation context provided, and necessary checklist items marked appropriately.
Linked Issues check ✅ Passed The PR successfully addresses issue #13074 by updating image repository URLs to ghcr.io in all specified sub-charts including config-api, auth-server, auth-server-key-rotation, persistence, scim, config, fido2, and casa.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cn-image-urls

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-dependencies Pull requests that update a dependency file labels Feb 7, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@charts/janssen/charts/auth-server/values.yaml`:
- Line 29: Remove the extra space after the colon for the YAML key "repository"
in values.yaml (the line showing repository: 
ghcr.io/janssenproject/jans/auth-server) so it reads with a single space after
the colon ("repository: ghcr.io/...") to satisfy yamllint's "too many spaces
after colon" rule.

moabu and others added 2 commits February 9, 2026 10:42
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
@moabu moabu merged commit 08b2066 into main Feb 9, 2026
4 of 9 checks passed
@moabu moabu deleted the cn-image-urls branch February 9, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(charts): change URL of image repo to ghcr.io in sub-charts

3 participants