-
Notifications
You must be signed in to change notification settings - Fork 161
chore(charts): change URL of image repo to ghcr.io in sub-charts #13190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: iromli <isman.firmansyah@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughMigrates many Janssen sub-chart image.repository values to ghcr.io and replaces top-level kc-scheduler/saml entries with a new shibboleth-idp configuration in the main chart, adding the shibboleth-idp chart and updating related README/values defaults. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@charts/janssen/charts/auth-server/values.yaml`:
- Line 29: Remove the extra space after the colon for the YAML key "repository"
in values.yaml (the line showing repository:
ghcr.io/janssenproject/jans/auth-server) so it reads with a single space after
the colon ("repository: ghcr.io/...") to satisfy yamllint's "too many spaces
after colon" rule.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Prepare
Description
Target issue
closes #13074
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Summary by CodeRabbit
New Features
Documentation
Chores