-
Notifications
You must be signed in to change notification settings - Fork 161
ci(jans-cedarling): upgrade python version #13194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughUpdates Python runtime from 3.10 to 3.11 across the flask-sidecar: Dockerfile base image and wheel filenames, pyproject.toml Python constraint, tox.ini test environment, and CI package build/signing matrix. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@jans-cedarling/flask-sidecar/Dockerfile`:
- Line 57: The Dockerfile uses an unquoted command substitution elsewhere (e.g.,
the wget/poetry invocations around the cedarling wheel), which can cause
word-splitting; fix by wrapping any $(...) command substitutions in double
quotes (e.g., change $(some-command) to "$(some-command)") for the wget/poetry
add lines and any other occurrences so the expanded value is treated as a single
argument.
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
jans-cedarling/flask-sidecar/Dockerfile (2)
76-76: 🧹 Nitpick | 🔵 TrivialConsider adding a
HEALTHCHECKinstruction.Static analysis (Checkov CKV_DOCKER_2, Trivy DS026) flags the missing
HEALTHCHECK. Sincecurlis already installed, a simple check would improve orchestrator-level health monitoring.💡 Example HEALTHCHECK
EXPOSE 5000 +HEALTHCHECK --interval=30s --timeout=5s --start-period=10s --retries=3 \ + CMD curl -f http://localhost:5000/ || exit 1Adjust the endpoint to an appropriate health/readiness path if one exists.
53-54: 🧹 Nitpick | 🔵 TrivialPre-existing: version regex is fragile.
The
sedpattern on line 53 uses unescaped.(matches any char) and only handles single-digit version components (e.g.,1.0.0but not1.10.0). Not introduced by this PR, but worth hardening if you're already touching this file.💡 Suggested regex improvement
- && version=$(sed -n 's/.*version = "\([0-9].[0-9].[0-9]\)"/\1/p' Cargo.toml) \ + && version=$(sed -n 's/.*version = "\([0-9]\+\.[0-9]\+\.[0-9]\+\)"/\1/p' Cargo.toml) \
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/build-packages.yml (1)
540-545:⚠️ Potential issue | 🟠 MajorAdd
python-version: '3.11'to thesetup-pythonaction.Line 540 invokes
actions/setup-pythonwithout apython-versioninput. Onubuntu-22.04runners, this defaults to Python 3.10 onPATH. However, line 545 passes-i python3.11to maturin, which requires thepython3.11interpreter to be available. Without an explicit version, the build will fail to findpython3.11.Proposed fix
- uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 + with: + python-version: '3.11' - uses: PyO3/maturin-action@86b9d133d34bc1b40018696f782949dac11bd380 # v1.49.4
Prepare
Description
Target issue
closes #13193
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Summary by CodeRabbit