Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Home Manager module #605

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Add Home Manager module #605

merged 7 commits into from
Dec 24, 2024

Conversation

benvonh
Copy link
Contributor

@benvonh benvonh commented Dec 23, 2024

Added module.nix to the nix folder.

README is updated to show how to use it.

A few design problems are:

  1. There is no clean way to reload the config. You have to stop HyprPanel and restart it.
  2. Waiting for feat: allow reading of JSON objects in the configuration #497 to be merged so that the config generation logic can be drastically simplified.
  3. Overwriting config.json through the GUI is a problem due to how Nix works. The best workaround is to generate a file highlighting the differences instead of overwriting it so that users can easily update their config in the Nix module. This has to be done manually by nature but would also be very nice to have (low priority).

Copy link
Collaborator

@orangci orangci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wonderful! one thing; fitting all this documentation in the readme would be a lot. i suggest instead putting it instead in the docs

edit: and while you're waiting for #497, you can just mark this as a draft PR

@orangci orangci added enhancement New feature or request nix for issues and pull requested related to Nix labels Dec 24, 2024
@benvonh
Copy link
Contributor Author

benvonh commented Dec 24, 2024

@orangci I replaced it with a link to the installation page.

Also, the module was made to handle without that PR but I'll set this as a draft anyway.

If anyone wants to try using it now, just change the flake input URL to my fork.

@orangci
Copy link
Collaborator

orangci commented Dec 24, 2024

Also, the module was made to handle without that PR but I'll set this as a draft anyway.

ah i see now, your wording in the original PR message didn't make this clear

is this ready, or do you need to do more work on it?

@orangci orangci dismissed their stale review December 24, 2024 09:49

resolved

@benvonh
Copy link
Contributor Author

benvonh commented Dec 24, 2024

Yes, it's ready - I wouldn't submit a PR if it wasn't xd

It's just that those design problems make the inside logic messy. But functionality-wise, it's all working. I'll slowly fix them at a later date.

@orangci
Copy link
Collaborator

orangci commented Dec 24, 2024

ill merge this then. thanks for the contribution 💖💖💖
edit: ah i need you to update your fork because i cant merge it otherwise

@orangci orangci marked this pull request as ready for review December 24, 2024 13:31
@benvonh
Copy link
Contributor Author

benvonh commented Dec 24, 2024

Done 👍

@orangci orangci merged commit 1b31f04 into Jas-SinghFSU:master Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nix for issues and pull requested related to Nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants