Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live reloading of configuration file #684

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

davfsa
Copy link
Contributor

@davfsa davfsa commented Dec 31, 2024

This also removes the need for a file with all the available configuration and a shadow configuration file.

Additionally, added several improvements:

  1. Reduce I/O on initial configuration loading by only reading file once, instead of once per option (scary! Hyprpanel has a lot of options)
  2. Remove unnecesary back and forth events when editing configuration

There were also old references to a "cache file", which is no longer a thing since the Astal migration, so renamed those too

This also removes the need for a file with all the available
configuration and a shadow configuration file.

Additionally, added several improvements:
1. Reduce I/O on initial configuration loading by only reading file once
2. Remove unnecesary back and forth events when editing configuration
@davfsa
Copy link
Contributor Author

davfsa commented Dec 31, 2024

Kind of closes #381, as it is now way nicer to edit these types of configuration, but im not sure :)

@Jas-SinghFSU
Copy link
Owner

Nice! I'll review this over the weekend when I get more time.

src/lib/option.ts Outdated Show resolved Hide resolved
src/lib/option.ts Outdated Show resolved Hide resolved
src/lib/option.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants