Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application Launcher #685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aetherall
Copy link

@Aetherall Aetherall commented Dec 31, 2024

Hi ! I discovered hyprpanel today and besides the app launcher it really does it all for me !

So I am proposing my help to add an optional one ( I will surely contribute some more features in the future )

For now this is a really crude draft of an application launcher menu ( dropdown & popup )

it is my first time using gtk and astal and surely made a lot of mistakes.
I couldnt make keyboard navigation work, even trying to use the Gtk3 ListBox and ListBoxRow.

Also I didnt do any styling for now and just reused notification menu styles.

hyprpanel t applicationsmenu

hyprpanel t applicationsmenudropdown

snapshot_2024-12-31_19-25-36

PS:

  • do you guys have live reload in development ?
  • is the .js extensions in imports mandatory for the code to build and the lsp to work in your system ? On my system it breaks (nix flakes) because astal pulled as typescript sources and only compiled along with hyperpanel so not resolvable in dev. Removing the .js extensions on astal package does fix it for me.
  • is a gtk4 migration planned ? I can contribute on that too to keep up with astal :)

Thanks for this awesome project !
Happy new year !

@Aetherall
Copy link
Author

My issue with imports seems to have be solved today, i'll rebase tomorrow :)

@Aetherall Aetherall force-pushed the feat/application-launcher branch 2 times, most recently from 31c2063 to 57fb593 Compare January 2, 2025 12:04
@Aetherall Aetherall force-pushed the feat/application-launcher branch 2 times, most recently from 247fb92 to 94101b7 Compare January 5, 2025 18:42
@Aetherall Aetherall force-pushed the feat/application-launcher branch from 94101b7 to 17ed97a Compare January 6, 2025 08:22
@Jas-SinghFSU
Copy link
Owner

Jas-SinghFSU commented Feb 4, 2025

Apologies for the late reply, been super busy at work and hoping to get back into the groove here.

do you guys have live reload in development ?

No, though I'm sure with some tooling you could set it up to some degree by monitoring file changes and auto-restarting the panel.

is the .js extensions in imports mandatory for the code to build and the lsp to work in your system ? On my system it breaks (nix flakes) because astal pulled as typescript sources and only compiled along with hyperpanel so not resolvable in dev. Removing the .js extensions on astal package does fix it for me.

Probably not since ESBuild (used by AGS) is smart enough to resolve paths without extensions. This is more-so just the default behavior of auto-imports on the typescript LSP.

is a gtk4 migration planned ? I can contribute on that too to keep up with astal :)

Yes :) But I haven't looked into GTK4 to see whether it would satisfy all of the requirements.

@Aetherall
Copy link
Author

Aetherall commented Feb 5, 2025

@Jas-SinghFSU Same ahah no worries

No, though I'm sure with some tooling you could set it up to some degree by monitoring file changes and auto-restarting the panel.

I made an PR on AGS to add support for the esbulid watch mode, i've been using it successfully on hyprpanel, but its yet to be reviewed. Aylur/ags#660

I've been using this Application Launcher since this MR, but I dont feel confortable to merge it until I get keyboard navigation support there.
I have no time to work on this right now so if anyone wants to tackle that feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants