Skip to content

Add ability to include additional files#18

Open
mheap wants to merge 2 commits into
JasonEtco:mainfrom
mheap:add-additional-files
Open

Add ability to include additional files#18
mheap wants to merge 2 commits into
JasonEtco:mainfrom
mheap:add-additional-files

Conversation

@mheap
Copy link
Copy Markdown
Contributor

@mheap mheap commented Jul 1, 2021

Include files other than main when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundling ncc using ncc due to Error: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'

Include files other than `main` when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundling `ncc` using `ncc` due to `Error: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'`
@endorama
Copy link
Copy Markdown

Just saw this and I would need the same functionality to include a license file with the releases.

@JasonEtco could you please consider this for merging?

@jonasgeiler
Copy link
Copy Markdown

I'd really like to have this feature!
Instead of an input option, how about just including the files matched in the "files" entry in package.json?

Example:

{
  "name": "your-action-name",
  "main": "dist/index.js",
  "files": [
    "dist/licenses.txt"
  ],
  "scripts": {
    "build": "npx @vercel/ncc build && npx convert-action"
  }
}

@hanseartic
Copy link
Copy Markdown

hanseartic commented Jan 18, 2023

@JasonEtco any chance you might want to integrate this or #24?

I would really like to include the README into the release tag (so that viewing older releases on the marketplace also shows the readme).

See for example an older version of this action itself:
grafik

@Zehir
Copy link
Copy Markdown

Zehir commented Mar 22, 2023

Any updates over here ?

@EddieWhi
Copy link
Copy Markdown

I'd really like this too. Love the workflow of this action but need to include a wasm file along side the ncc generated index.js. @JasonEtco?

EddieWhi pushed a commit to primait/build-and-tag-action that referenced this pull request Jul 4, 2023
Cherry-picked from mheap/build-and-tag-action@ 3c1fd24 which is and open PR on JasonEtco/build-and-tag-action: JasonEtco#18

Include files other than `main` when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundling `ncc` using `ncc` due to `Error: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'`
@EddieWhi
Copy link
Copy Markdown

@mheap turns out there's a bug in the PR (technically a bug exposed by this PR as it enables deployment of binaries). I forked into our org and used it to deploy a wasm with an action (as mentioned before) but discovered that the binary was corrupted by the roundtrip through utf-8. See primait@183ecd8

@mheap
Copy link
Copy Markdown
Contributor Author

mheap commented Jul 30, 2023

@EddieWhi Excellent catch! I've cherry picked in to this PR in case it helps anyone else

hanseartic added a commit to hanseartic/github-versioned-release that referenced this pull request Aug 23, 2023
The readme should be included in the tag as well. Otherwise when selecting an older version in the marketplace there is no readme displayed.

See also here: JasonEtco/build-and-tag-action#18 (comment)
hanseartic added a commit to hanseartic/github-versioned-release that referenced this pull request Aug 23, 2023
The readme should be included in the tag as well. Otherwise when selecting an older version in the marketplace there is no readme displayed.

See also here: JasonEtco/build-and-tag-action#18 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants