Skip to content

Route Parameter Variable Ordering in Marten Batch Queries #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jan 12, 2026
Merged

Route Parameter Variable Ordering in Marten Batch Queries #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Http/Wolverine.Http.Tests/Marten/reacting_to_read_aggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ await theHost.Scenario(x =>

public static class LetterAggregateEndpointWithValidation
{
public static void Before(Guid id) { }

public static ProblemDetails Validate(LetterAggregate letters)
{
if (letters.ACount is 0)
Expand All @@ -142,6 +144,8 @@ public static LetterAggregate PostLetter([WriteAggregate(Required = true, OnMiss

public static class LetterAggregateEndpoint
{
public static void Load(Guid id) { }

#region sample_read_aggregate_fine_grained_validation_control

// Straight up 404 on missing
Expand Down
12 changes: 12 additions & 0 deletions src/Persistence/Wolverine.Marten/Codegen/MartenQueryingFrame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,17 @@ public override IEnumerable<Variable> FindVariables(IMethodVariables chain)

_cancellation = chain.FindVariable(typeof(CancellationToken));
yield return _cancellation;

// This ensures those variables are declared before we try to use them in the batch enlistment code
foreach (var op in _operations)
{
if (op is Frame frame)
{
foreach (var variable in frame.FindVariables(chain))
{
yield return variable;
}
}
}
}
}
Loading