Skip to content

Return the correct error message when ISideEffect is directly returned by a handler #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jan 12, 2026
Merged

Return the correct error message when ISideEffect is directly returned by a handler #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Wolverine/ISideEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public Frame Apply(IChain chain, Variable variable, GenerationRules rules,

private static void applySideEffectExecution(Variable effect, IChain chain)
{
if (effect.GetType() == typeof(ISideEffect))
if (effect.VariableType == typeof(ISideEffect))
{
throw new InvalidOperationException($"Return the concrete type of ISideEffect so that Wolverine can 'know' how to call into your side effect and not ISideEffect itself");
}
Expand Down
Loading