Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INSERT and UPDATE parsing #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gpittarelli
Copy link

@gpittarelli gpittarelli commented Apr 10, 2018

Implements parsing for INSERT and UPDATE queries, per the MySQL 5.7 grammar. Includes pretty printing + test cases.

(Note: for my own purposes, I've published this branch under @gpittarelli/js-sql-parser)

@albin3
Copy link
Member

albin3 commented Apr 11, 2018

Great, i'm a little busy these days, i will review it later.

@albin3
Copy link
Member

albin3 commented Jul 15, 2018

hi, @gpittarelli .

I reviewed the insert part in this pr and there are something need to change / some questions need to confirm:

  1. following https://dev.mysql.com/doc/refman/5.7/en/insert.html , simple_table_factor grammar may be should be replaced by identifier.
  2. more test cases are needed for for the new code.
  3. suggestion: format the code more similar with document in https://dev.mysql.com/doc/refman/5.7/en/insert.html , such as there are three insert grammars in document, we also write it into three lines. So, it's more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants