Add Cityscapes dataset adapter - #577
Merged
Merged
Conversation
dpascualhe
changed the title
dpascualhe
reviewed
May 20, 2026
dpascualhe
left a comment
dpascualhe
left a comment
Collaborator
There was a problem hiding this comment.
So far so good! 😄 Just keep in mind the sphinx format for the docstrings (I guess you can setup some extension to help you with that if you're working with vscode) and avoid pushing local paths
Collaborator
Author
|
Thanks @dpascualhe ! I’ll keep this in mind going forward. I have pushed the latest version with the dataset adapter functions and Sphinx-formatted docstrings, and I’ll make sure to avoid local paths in future changes. |
Collaborator
|
Hi @tejasstanley ! Can you resolve the poetry.lock file conflict? We bumped recently some versions due to security issues. We are ready to merge afterwards 😄 |
tejasstanley
marked this pull request as ready for review
May 26, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #576.
This PR adds an initial Cityscapes dataset adapter.
Current status
This is still in progress. The dataset loading and ontology mapping are mostly implemented. The
CityscapesImageSegmentationDatasetwrapper is not added yet.Changes
cityscapesscriptsleftImg8bitandgtFineTODO
CityscapesImageSegmentationDataset