Skip to content

Remove chmod 777 in filesystem layer for rootless container compatibility #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karttikjangid wants to merge 1 commit into
base: humble-devel
Choose a base branch
from
+0 −5
Open

Remove chmod 777 in filesystem layer for rootless container compatibility #3953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions academy/file_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,28 +267,24 @@ def create(self, path: str, content):

with open(path, "w") as f:
f.write(content)
os.chmod(path, 0o777)

def create_binary(self, path: str, content):
super().create_binary(path, content)

with open(path, "wb") as f:
f.write(content)
os.chmod(path, 0o777)

def write(self, path: str, content):
super().write(path, content)

with open(path, "w") as f:
f.write(content)
os.chmod(path, 0o777)

def write_binary(self, path: str, content):
super().write_binary(path, content)

with open(path, "wb") as f:
f.write(content)
os.chmod(path, 0o777)

def read(self, path: str) -> str:
super().read(path)
Expand Down Expand Up @@ -324,7 +320,6 @@ def mkdir(self, path: str):
super().mkdir(path)

os.makedirs(path)
os.chmod(path, mode=0o777)

def renamefile(self, old_path: str, new_path: str):
super().renamefile(old_path, new_path)
Expand Down