Remove some duplicate and bogus rankings, correct a couple of errors in rankings/points#250
Open
Epithumia wants to merge 7 commits intoJeffSackmann:masterfrom
Open
Remove some duplicate and bogus rankings, correct a couple of errors in rankings/points#250Epithumia wants to merge 7 commits intoJeffSackmann:masterfrom
Epithumia wants to merge 7 commits intoJeffSackmann:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR linked to issue #249
The true duplicate rows were removed first, then for all rankings that had multiple entries for a (date,player) pair, I used the atptour website to manually review and remove bogus rows, and in a couple of cases, fix the ranking and/or points.