rm unnecessary deepcopy #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string-conversion routines made an unnecessary
deepcopyof the result ofunsafe_string, which is already documented to be a copy.Also should be no need for the
pointercall, sinceunsafe_stringalready has aCstringmethod.(The
trimzerosfunction also does a lot of unnecessary copying, but fixing this is more work. Ideally you would do the trimming at the same time as copying from theCstringpointer.)