OJ-54337 Use repo slug for bitbucket URLs - #450
Merged
Conversation
|
gunthercox
marked this pull request as ready for review
April 30, 2026 16:25
ashleyredzko
approved these changes
May 1, 2026
ashleyredzko
reviewed
May 1, 2026
| for i, repo in enumerate(standardized_repos, start=1): | ||
| with logging_helper.log_loop_iters('repo for branch commits', i, 1): | ||
| pull_since = pull_since_date_for_repo( | ||
| server_git_instance_info, repo.project.login, repo.id, 'commits' |
Contributor
There was a problem hiding this comment.
Does this also need the slug?
ashleyredzko
reviewed
May 1, 2026
| @@ -210,7 +207,7 @@ | |||
| server_git_instance_info, repo.project.login, repo.id, 'prs' | |||
Contributor
There was a problem hiding this comment.
Checking here, should this use the slug as well?
Contributor
Author
There was a problem hiding this comment.
I'll double check, but I believe this and the other line can both be kept as UUIDs. The goal is to keep the UUID usage internally, but ensure API requests are all made using the slug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant API Documentation: