Rework FromStr derive
#468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
|
ping @JelteF |
JelteF
approved these changes
May 8, 2025
tyranron
added a commit
that referenced
this pull request
May 13, 2025
Required for #467 Requires #468 ## Synopsis We support flat structs for `Display`: ```rust #[derive(Display)] struct Foo; ``` But `FromStr` doesn't support it. ## Solution Allow using `#[derive(FromStr)]` on structs with no fields. Similarly to enums it will use fuzzy matching. Exact matching would be possible to enable in #469 by using `#[from_str(rename_all = "...")]` attribute.
tyranron
added a commit
that referenced
this pull request
May 24, 2025
Resolves #216 Requires #468, #469 ## Synopsis We have `#[display(rename_all = "...")]` attribute for flat enums. The counterpart for `FromStr` derive is missing. ## Solution This PR adds support `#[from_str(rename_all = "...")]` attribute on enums. Once this attribute is specified, the matching is always exact (for now, by default, matching could be fuzzy if there is no similarly named variants).
tyranron
added a commit
that referenced
this pull request
Jun 2, 2025
Follows #468 ## Synopsis In #468, the `FromStr` derive was reworked. However, the check for inferring trait bounds for the inner type was simplified to `!generics.params.is_empty()`, which is not a very correct assumption, because applies the redundant bounds for cases like these: ```rust #[derive(FromStr)] struct Int<const N: usize>(i32); ``` ```rust impl<const N: usize> derive_more::core::str::FromStr for Int<N> where i32: derive_more::core::str::FromStr { /* ... */} ``` ## Solution Use `utils::GenericSearch` machinery as a common mechanism for this purpose. ## Additionally Refactored `utils::GenericSearch` to use `Vec` instead `HashSet`, because in the majority of cases there won't be any duplicates in generic parameters and their number won't be big enough for a `HashSet` to make a positive performance benefit. At the same moment, `HashSet` requires `Hash` implementation of `syn::Ident` which is gated by the `syn/extra-traits` feature, and thus we can lift it requirement for `utils::GenericSearch` usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #467, #469
This PR fully reworks
FromStrderive implementation to avoid using oldutilsmachinery.Also, adds
compile_failtests forFromStr.Checklist
Documentation is updated(not required)CHANGELOG entry is added(not required)