Improve browser extension #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup how actions are built. - Article actions are now built, added and removed with an object. Close #392
It causes errors when requests are run in parallel.
It’s to uniformize naming across the code base. We used URLs for feeds but link for articles. Now, we have URL everywhere. Close #404
Since we need to use FeedDeletedArticle to handle the cases when an article is linked to a feed, we just import this model dynamically and make an exception to our import policy.
We can filter them by URLs. Close #399
Some invalid articles may have multiple h1, keep them in this case since they are "normal" article titles and thus must be kept. Close #405
We do this in the extension to only display the subscribed icon if we are subscribed and the feed is enabled.
Jenselme
force-pushed
the
improve-browser-extension
branch
from
41d3908 to
e4907d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.