accept JSON add-torrent responses from qBittorrent#54
Open
sgerner wants to merge 2 commits into
Open
Conversation
JeremiahM37
requested changes
Jun 1, 2026
Owner
JeremiahM37
left a comment
JeremiahM37
left a comment
There was a problem hiding this comment.
The qbittorrent.go change itself looks fine. The test file is the problem — see inline.
| func TestLogin_QB4x_OkBody(t *testing.T) { | ||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| http.SetCookie(w, &http.Cookie{Name: "SID", Value: "session4x"}) | ||
| func TestQBittorrentAddTorrentAcceptsJSONSuccess(t *testing.T) { |
Owner
There was a problem hiding this comment.
This drops ~210 lines of tests that have nothing to do with the new JSON parsing:
- TestLogin_QB4x_OkBody
- TestLogin_QB5x_NoContentWithSessionCookie
- TestLogin_QB5x_EmptyBodyWithSessionCookie
- TestLogin_QB4x_FailsBody
- TestLogin_Banned
- TestLogin_EmptyBodyNoCookieFails
- TestMapTorrentStatus / TestMapSABStatus / TestValidTransitions
Can you restore these verbatim? Losing TestLogin_Banned in particular is a regression — qBit IP-bans on failed logins and that test guards against silently breaking the detection.
Also worth adding to the new code: a test for the literal "Ok." success path (stock qBit 4.x), and one for a non-2xx HTTP response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qBittorrent returns a JSON success payload on add-torrent in this environment, and librarr was treating anything other than literal Ok. as a failure.
What changed:
Validation: